From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06036C282CE for ; Fri, 5 Apr 2019 18:59:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7FD92171F for ; Fri, 5 Apr 2019 18:59:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731750AbfDES7D (ORCPT ); Fri, 5 Apr 2019 14:59:03 -0400 Received: from mga03.intel.com ([134.134.136.65]:48195 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731684AbfDES7D (ORCPT ); Fri, 5 Apr 2019 14:59:03 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2019 11:59:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,313,1549958400"; d="scan'208";a="140336510" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.181]) by orsmga003.jf.intel.com with ESMTP; 05 Apr 2019 11:59:02 -0700 Date: Fri, 5 Apr 2019 11:59:02 -0700 From: Sean Christopherson To: Thomas Gleixner Cc: LKML , x86@kernel.org, Andy Lutomirski , Josh Poimboeuf Subject: Re: [patch V2 07/29] x86/exceptions: Make IST index zero based Message-ID: <20190405185902.GA15808@linux.intel.com> References: <20190405150658.237064784@linutronix.de> <20190405150929.042846930@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190405150929.042846930@linutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 05, 2019 at 05:07:05PM +0200, Thomas Gleixner wrote: > The defines for the exception stack (IST) array in the TSS are using the > SDM convention IST1 - IST7. That causes all sorts of code to subtract 1 for > array indices related to IST. That's confusing at best and does not provide > any value. > > Make the indices zero based and fixup the usage sites. The only code which > needs to adjust the 0 based index is the interrupt descriptor setup which > needs to add 1 now. > > Signed-off-by: Thomas Gleixner > --- Reviewed-by: Sean Christopherson