From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4219BC282CE for ; Mon, 8 Apr 2019 07:43:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1249520880 for ; Mon, 8 Apr 2019 07:43:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726541AbfDHHnI (ORCPT ); Mon, 8 Apr 2019 03:43:08 -0400 Received: from mga14.intel.com ([192.55.52.115]:8352 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725871AbfDHHnH (ORCPT ); Mon, 8 Apr 2019 03:43:07 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 00:43:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,324,1549958400"; d="scan'208";a="221485558" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by orsmga001.jf.intel.com with SMTP; 08 Apr 2019 00:43:03 -0700 Received: by lahna (sSMTP sendmail emulation); Mon, 08 Apr 2019 10:43:02 +0300 Date: Mon, 8 Apr 2019 10:43:02 +0300 From: Mika Westerberg To: Binbin Wu Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, andriy.shevchenko@linux.intel.com Subject: Re: [PATCH] intel-lpss: Set the device in reset state when init Message-ID: <20190408074302.GD3622@lahna.fi.intel.com> References: <1554702118-20184-1-git-send-email-binbin.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1554702118-20184-1-git-send-email-binbin.wu@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 08, 2019 at 01:41:58PM +0800, Binbin Wu wrote: > In virtualized setup, when system reboots due to warm > reset interrupt storm is seen. > > Call Trace: > > dump_stack+0x70/0xa5 > __report_bad_irq+0x2e/0xc0 > note_interrupt+0x248/0x290 > ? add_interrupt_randomness+0x30/0x220 > handle_irq_event_percpu+0x54/0x80 > handle_irq_event+0x39/0x60 > handle_fasteoi_irq+0x91/0x150 > handle_irq+0x108/0x180 > do_IRQ+0x52/0xf0 > common_interrupt+0xf/0xf > > RIP: 0033:0x76fc2cfabc1d > Code: 24 28 bf 03 00 00 00 31 c0 48 8d 35 63 77 0e 00 48 8d 15 2e > 94 0e 00 4c 89 f9 49 89 d9 4c 89 d3 e8 b8 e2 01 00 48 8b 54 24 18 > <48> 89 ef 48 89 de 4c 89 e1 e8 d5 97 01 00 84 c0 74 2d 48 8b 04 > 24 > RSP: 002b:00007ffd247c1fc0 EFLAGS: 00000293 ORIG_RAX: ffffffffffffffda > RAX: 0000000000000000 RBX: 00007ffd247c1ff0 RCX: 000000000003d3ce > RDX: 0000000000000000 RSI: 00007ffd247c1ff0 RDI: 000076fc2cbb6010 > RBP: 000076fc2cded010 R08: 00007ffd247c2210 R09: 00007ffd247c22a0 > R10: 000076fc29465470 R11: 0000000000000000 R12: 00007ffd247c1fc0 > R13: 000076fc2ce8e470 R14: 000076fc27ec9960 R15: 0000000000000414 > handlers: > [<000000000d3fa913>] idma64_irq > Disabling IRQ #27 > > To avoid interrupt storm, set the device in reset state > before bringing out the device from reset state. > > Signed-off-by: Binbin Wu I think the correct subject line should be: "mfd: intel-lpss: Set the device in reset state when init" Regardless of that, Acked-by: Mika Westerberg