From: Christoph Hellwig <hch@lst.de>
To: Jie Zhang <jie.zhang@analog.com>
Cc: Mike Frysinger <vapier@gentoo.org>,
David Howells <dhowells@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: CONFIG_* symbols in UAPI headers?
Date: Mon, 8 Apr 2019 14:46:40 +0200 [thread overview]
Message-ID: <20190408124640.GA607@lst.de> (raw)
I just stumbled over the MAP_UNINITIALIZED defintion, initially
added by:
commit ea637639591def87a54cea811cbac796980cb30d
Author: Jie Zhang <jie.zhang@analog.com>
Date: Mon Dec 14 18:00:02 2009 -0800
nommu: fix malloc performance by adding uninitialized flag
The defintion depends on CONFIG_MMAP_ALLOW_UNINITIALIZED, which
will never be set by userspace. How is this supposed to work?
Shoudn't we define the symbol unconditionally and just turn it
into a no-op in the implementation?
There are a few similar issues, like struct elf_prstatus having
a different layout depending on CONFIG_BINFMT_ELF_FDPIC, or
MAX_SHARED_LIBS defending on CONFIG_BINFMT_SHARED_FLAT.
next reply other threads:[~2019-04-08 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 12:46 Christoph Hellwig [this message]
2019-04-08 13:58 ` CONFIG_* symbols in UAPI headers? Arnd Bergmann
2019-04-09 18:17 ` David Howells
2019-04-09 19:11 ` Paul Bolle
2019-04-09 20:54 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408124640.GA607@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=jie.zhang@analog.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox