From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13286C10F13 for ; Mon, 8 Apr 2019 19:31:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0E482083E for ; Mon, 8 Apr 2019 19:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726953AbfDHTbA (ORCPT ); Mon, 8 Apr 2019 15:31:00 -0400 Received: from muru.com ([72.249.23.125]:44858 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbfDHTbA (ORCPT ); Mon, 8 Apr 2019 15:31:00 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 8057280AA; Mon, 8 Apr 2019 19:31:13 +0000 (UTC) Date: Mon, 8 Apr 2019 12:30:55 -0700 From: Tony Lindgren To: Dan Murphy Cc: Pavel Machek , Jacek Anaszewski , robh@kernel.org, lee.jones@linaro.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL v2] LM3532 backlight support improvements and relocation Message-ID: <20190408193055.GN49658@atomide.com> References: <20190407190951.27288-1-jacek.anaszewski@gmail.com> <20190407221740.GA6327@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dan Murphy [190408 15:54]: > On 4/7/19 5:17 PM, Pavel Machek wrote: > > Plus, I'd kind of expect ALS enabled/disabled to be runtime controled, > > not from the device tree. > > We can always add runtime override control to the driver. Yeah that sounds good to me :) Sounds like this can be done with follow up patches though. > Just need to see if there is a common interface from input or IIO we can adopt. Hmm can the lm3532 registers actually show the value for the ALS sensors? Regards, Tony