From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3089C10F13 for ; Mon, 8 Apr 2019 20:27:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E5FC21841 for ; Mon, 8 Apr 2019 20:27:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728623AbfDHU1A (ORCPT ); Mon, 8 Apr 2019 16:27:00 -0400 Received: from mga11.intel.com ([192.55.52.93]:18868 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726509AbfDHU1A (ORCPT ); Mon, 8 Apr 2019 16:27:00 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 13:26:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,326,1549958400"; d="scan'208";a="162516490" Received: from agluck-desk.sc.intel.com (HELO agluck-desk) ([10.3.52.160]) by fmsmga001.fm.intel.com with ESMTP; 08 Apr 2019 13:27:00 -0700 Date: Mon, 8 Apr 2019 13:26:59 -0700 From: "Luck, Tony" To: "Ghannam, Yazen" Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bp@suse.de" , "x86@kernel.org" Subject: Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu Message-ID: <20190408202659.GA5232@agluck-desk> References: <20190408141205.12376-1-Yazen.Ghannam@amd.com> <20190408141205.12376-5-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190408141205.12376-5-Yazen.Ghannam@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 08, 2019 at 02:12:17PM +0000, Ghannam, Yazen wrote: > +DEFINE_PER_CPU_READ_MOSTLY(u8, num_banks); > +EXPORT_PER_CPU_SYMBOL_GPL(num_banks); The name "num_banks" is a bit generic for an exported symbol. I think it should have a "mce_" prefix. -Tony