From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu
Date: Mon, 8 Apr 2019 22:50:13 +0200 [thread overview]
Message-ID: <20190408205013.GN15689@zn.tnic> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7E8F6A61@ORSMSX104.amr.corp.intel.com>
On Mon, Apr 08, 2019 at 08:42:36PM +0000, Luck, Tony wrote:
> > Actually, it should not be exported at all. A function returning the num
> > banks is better instead.
>
> Are all the places it is used in non-pre-emptible sections of code? Looping
> in the CMCI and #MC handlers should be fine. But do we need get_cpu()/put_cpu()
> in any places?
That export is needed only in the mce injector. Actually, it would be
much cleaner if the injector would find out the count straight from the
MSR as it does now, but be changed to do rdmsr_on_cpu() now, since can
have different num_banks on a CPU.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-04-08 20:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 14:12 [PATCH RESEND 0/5] Handle MCA banks in a per_cpu way Ghannam, Yazen
2019-04-08 14:12 ` [PATCH RESEND 1/5] x86/MCE: Make struct mce_banks[] static Ghannam, Yazen
2019-04-08 14:12 ` [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu way Ghannam, Yazen
2019-04-08 17:51 ` Borislav Petkov
2019-04-08 18:55 ` Ghannam, Yazen
2019-04-09 20:34 ` Borislav Petkov
2019-04-10 16:36 ` Ghannam, Yazen
2019-04-10 16:40 ` Borislav Petkov
2019-04-10 16:58 ` Ghannam, Yazen
2019-04-10 17:25 ` Borislav Petkov
2019-04-10 19:41 ` Ghannam, Yazen
2019-04-10 20:04 ` Borislav Petkov
2019-04-08 14:12 ` [PATCH RESEND 3/5] x86/MCE/AMD: Don't cache block addresses on SMCA systems Ghannam, Yazen
2019-04-08 14:12 ` [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu Ghannam, Yazen
2019-04-08 20:26 ` Luck, Tony
2019-04-08 20:34 ` Borislav Petkov
2019-04-08 20:42 ` Luck, Tony
2019-04-08 20:50 ` Borislav Petkov [this message]
2019-04-08 22:48 ` Ghannam, Yazen
2019-04-08 23:23 ` Luck, Tony
2019-04-08 23:37 ` Ghannam, Yazen
2019-04-09 11:38 ` Borislav Petkov
2019-04-08 14:12 ` [PATCH RESEND 5/5] x86/MCE: Save MCA control bits that get set in hardware Ghannam, Yazen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408205013.GN15689@zn.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox