From: Tony Lindgren <tony@atomide.com>
To: Dan Murphy <dmurphy@ti.com>
Cc: Pavel Machek <pavel@ucw.cz>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
robh@kernel.org, lee.jones@linaro.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL v2] LM3532 backlight support improvements and relocation
Date: Tue, 9 Apr 2019 07:56:49 -0700 [thread overview]
Message-ID: <20190409145649.GE2839@atomide.com> (raw)
In-Reply-To: <df6e1bf1-2588-46d0-c115-b6827174bb9b@ti.com>
* Dan Murphy <dmurphy@ti.com> [190408 20:04]:
> Tony
>
> On 4/8/19 2:30 PM, Tony Lindgren wrote:
> > * Dan Murphy <dmurphy@ti.com> [190408 15:54]:
> > > On 4/7/19 5:17 PM, Pavel Machek wrote:
> > > > Plus, I'd kind of expect ALS enabled/disabled to be runtime controled,
> > > > not from the device tree.
> > > We can always add runtime override control to the driver.
> > Yeah that sounds good to me :) Sounds like this can be done
> > with follow up patches though.
> >
> > > Just need to see if there is a common interface from input or IIO we can adopt.
> > Hmm can the lm3532 registers actually show the value
> > for the ALS sensors?
>
>
> No it can only report the current configured ALS zone not the LUX value.
Sounds like it should be just enable/disable or auto/manual
type toggle then in /sys somewhere for the users.
Not sure if ledtrig-backlight-auto vs ledtrig-backlight would
make sense?
Regards,
Tony
prev parent reply other threads:[~2019-04-09 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-07 19:09 [GIT PULL v2] LM3532 backlight support improvements and relocation Jacek Anaszewski
2019-04-07 22:17 ` Pavel Machek
2019-04-07 22:50 ` Pavel Machek
2019-04-08 15:42 ` Dan Murphy
2019-04-08 15:53 ` Dan Murphy
2019-04-08 19:30 ` Tony Lindgren
2019-04-08 20:03 ` Dan Murphy
2019-04-09 14:56 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409145649.GE2839@atomide.com \
--to=tony@atomide.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).