From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 623E8C10F0E for ; Tue, 9 Apr 2019 15:28:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2EE53208C0 for ; Tue, 9 Apr 2019 15:28:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbfDIP2u (ORCPT ); Tue, 9 Apr 2019 11:28:50 -0400 Received: from mga11.intel.com ([192.55.52.93]:8859 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbfDIP2t (ORCPT ); Tue, 9 Apr 2019 11:28:49 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 08:28:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="149361869" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga002.jf.intel.com with ESMTP; 09 Apr 2019 08:28:47 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hDsg2-0004kB-8r; Tue, 09 Apr 2019 18:28:46 +0300 Date: Tue, 9 Apr 2019 18:28:46 +0300 From: Andy Shevchenko To: Mika Westerberg Cc: Binbin Wu , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH] pinctrl: pinctrl-intel: move gpio suspend/resume to noirq phase Message-ID: <20190409152846.GT9224@smile.fi.intel.com> References: <1554720566-29103-1-git-send-email-binbin.wu@intel.com> <20190408124348.GQ9224@smile.fi.intel.com> <20190408125126.GR3622@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190408125126.GR3622@lahna.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 08, 2019 at 03:51:26PM +0300, Mika Westerberg wrote: > On Mon, Apr 08, 2019 at 03:43:48PM +0300, Andy Shevchenko wrote: > > On Mon, Apr 08, 2019 at 06:49:26PM +0800, Binbin Wu wrote: > > > In current driver, SET_LATE_SYSTEM_SLEEP_PM_OPS is used to install the > > > callbacks for suspend/resume. > > > GPIO pin may be used as the interrupt pin by some device. However, using > > > SET_LATE_SYSTEM_SLEEP_PM_OPS() to install the callbacks, the resume > > > callback is called after resume_device_irqs(). Unintended interrupts may > > > arrive due to resuming device irqs first, but the GPIO controller is not > > > properly restored. > > > > > > Normally, for a SMP system, there are multiple cores, so even when there are > > > unintended interrupts, BSP gets the chance to init the gpio chip soon. > > > > gpio -> GPIO. > > (If Mika is okay with patch content, I may fix this when applying) > > Yup, this looks good to me. > > Acked-by: Mika Westerberg Pushed to my review and testing queue, thanks! -- With Best Regards, Andy Shevchenko