From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C809C10F0E for ; Tue, 9 Apr 2019 18:01:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F8B62084F for ; Tue, 9 Apr 2019 18:01:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726629AbfDISBr (ORCPT ); Tue, 9 Apr 2019 14:01:47 -0400 Received: from mga04.intel.com ([192.55.52.120]:56294 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726383AbfDISBq (ORCPT ); Tue, 9 Apr 2019 14:01:46 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 11:01:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,330,1549958400"; d="scan'208";a="132827104" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga008.jf.intel.com with ESMTP; 09 Apr 2019 11:01:44 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hDv43-0006j1-C0; Tue, 09 Apr 2019 21:01:43 +0300 Date: Tue, 9 Apr 2019 21:01:43 +0300 From: Andy Shevchenko To: Christoph Hellwig Cc: Vinod Koul , dmaengine@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] dmaengine: idma64: Move driver name to the header Message-ID: <20190409180143.GZ9224@smile.fi.intel.com> References: <20190409150219.15094-1-andriy.shevchenko@linux.intel.com> <20190409163728.GA26872@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190409163728.GA26872@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 09, 2019 at 09:37:28AM -0700, Christoph Hellwig wrote: > On Tue, Apr 09, 2019 at 06:02:19PM +0300, Andy Shevchenko wrote: > > There are two drivers that are relying on the iDMA 64-bit driver name > > to match. Instead of duplicating string in both of them, dedicate > > a header file and share it between users. > > Hmm. Why do we have two separate drivers for the same name? > > Something is rather fishy there. We would like to be sure that the DMA controller driver is loaded before its consumers. -- With Best Regards, Andy Shevchenko