Re: [PATCH] Revert "drm/vmwgfx: Improve on IOMMU detection"

Thomas Hellstrom
2019-04-08T20:05:54Z

On Mon, 2019-04-08 at 12:55 +0200, Christoph Hellwig wrote:
> This reverts commit 9ddac734aa310c5fbc0ec93602335d2a39092451.

IMHO, rather than reverting, I'd like to see the dma API provide a
function telling us whether streaming DMA operations are coherent or
not.

With that we could fix all drivers that would otherwise just blow up if
somebody happened to enable swiotlb with bounce buffers...

/Thomas

> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 19 ++-----------------
> 1 file changed, 2 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> index 6165fe2c4504..9294b76c8084 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> @@ -26,7 +26,6 @@
>
> *********************************************************************
> *****/
> #include <linux/module.h>
> #include <linux/console.h>
> -#include <linux/dma-mapping.h>
>
> #include <drm/drmP.h>
> #include "vmwgfx_drv.h"
> @@ -35,6 +34,7 @@
> #include <drm/ttm/ttm_placement.h>
> #include <drm/ttm/ttm_bo_driver.h>
> #include <drm/ttm/ttm_module.h>
> +#include <linux/intel-iommu.h>
>
> #define VMWGFX_DRIVER_DESC "Linux drm driver for VMware graphics
> devices"
> #define VMWGFX_CHIP_SVGAII 0
> @@ -545,21 +545,6 @@ static void vmw_get_initial_size(struct
> vmw_private *dev_priv)
> dev_priv->initial_height = height;
> }
>
> -/**
> - * vmw_assume_iommu - Figure out whether coherent dma-remapping
> might be
> - * taking place.
> - * @dev: Pointer to the struct drm_device.
> - *
> - * Return: true if iommu present, false otherwise.
> - */
> -static bool vmw_assume_iommu(struct drm_device *dev)
> -{
> - const struct dma_map_ops *ops = get_dma_ops(dev->dev);
> -
> - return !dma_is_direct(ops) && ops &&
> - ops->map_page != dma_direct_map_page;
> -}
> -
> /**
> * vmw_dma_select_mode - Determine how DMA mappings should be set up
> for this
> * system.
> @@ -583,7 +568,7 @@ static int vmw_dma_select_mode(struct vmw_private
> *dev_priv)
>
> if (vmw_force_coherent)
> dev_priv->map_mode = vmw_dma_alloc_coherent;
> - else if (vmw_assume_iommu(dev_priv->dev))
> + else if (intel_iommu_enabled)
> dev_priv->map_mode = vmw_dma_map_populate;
> else if (!vmw_force_iommu)
> dev_priv->map_mode = vmw_dma_phys;