From: Madhumthia Prabakaran <madhumithabiw@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data
Date: Wed, 10 Apr 2019 14:49:09 -0500 [thread overview]
Message-ID: <20190410194908.GA13242@madhuleo> (raw)
In-Reply-To: <20190410064954.GE6095@kadam>
On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote:
> On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote:
> > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h
> > index bafb2c30e7fb..b0623c936940 100644
> > --- a/drivers/staging/rtl8723bs/include/drv_types.h
> > +++ b/drivers/staging/rtl8723bs/include/drv_types.h
> > @@ -220,7 +220,7 @@ struct registry_priv
> > #define BSSID_SZ(field) sizeof(((struct wlan_bssid_ex *) 0)->field)
> >
> > #include <drv_types_sdio.h>
> > -#define INTF_DATA SDIO_DATA
> > +#define INTF_DATA struct sdio_data
> >
>
> Just get rid of INTF_DATA data as well. It's only used once a bit lower
> in the file. (Get rid of the ifdef around it).
But, reference of INTF_DATA is also included in file
./drivers/staging/rtl8723bs/include/drv_types.h:487:
return &dvobj->intf_data.func->dev;
thanks for the review
madhumitha
>
> regards,
> dan carpenter
>
>
>
next prev parent reply other threads:[~2019-04-10 19:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 16:16 [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data Madhumitha Prabakaran
2019-04-10 6:49 ` Dan Carpenter
2019-04-10 19:49 ` Madhumthia Prabakaran [this message]
2019-04-11 7:22 ` Dan Carpenter
2019-04-11 8:13 ` Dan Carpenter
2019-04-11 15:33 ` Madhumthia Prabakaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410194908.GA13242@madhuleo \
--to=madhumithabiw@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox