From: Sam Ravnborg <sam@ravnborg.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVER FOR BOCHS VIRTUAL GPU"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] drm/bochs: use simple display pipe
Date: Wed, 10 Apr 2019 23:22:40 +0200 [thread overview]
Message-ID: <20190410212240.GA31691@ravnborg.org> (raw)
In-Reply-To: <20190410074828.10296-1-kraxel@redhat.com>
Hi Gerd.
>
> #include <drm/drm_gem.h>
>
> @@ -69,9 +70,8 @@ struct bochs_device {
> struct edid *edid;
>
> /* drm */
> - struct drm_device *dev;
> - struct drm_crtc crtc;
> - struct drm_encoder encoder;
> + struct drm_device *dev;
> + struct drm_simple_display_pipe pipe;
> struct drm_connector connector;
Have you considered to embed drm_device in the bochs_device struct?
This is the new way to do it.
This should likely be a follow-up patch...
Rest of the patch looked good.
Did not do a proper review but you can add my:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
prev parent reply other threads:[~2019-04-10 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 7:48 [PATCH] drm/bochs: use simple display pipe Gerd Hoffmann
2019-04-10 12:55 ` Noralf Trønnes
2019-04-10 21:22 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410212240.GA31691@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox