From: Sinan Kaya <okaya@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Sinan Kaya <okaya@kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Johannes Weiner <hannes@cmpxchg.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Nicholas Piggin <npiggin@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Vasily Gorbik <gor@linux.ibm.com>, Adrian Reber <adrian@lisas.de>,
Richard Guy Briggs <rgb@redhat.com>
Subject: [PATCH v1] init: Do not select DEBUG_KERNEL by default
Date: Wed, 10 Apr 2019 21:26:25 +0000 [thread overview]
Message-ID: <20190410212627.29514-1-okaya@kernel.org> (raw)
We can't seem to have a kernel with CONFIG_EXPERT set but
CONFIG_DEBUG_KERNEL unset these days.
While some of the features under the CONFIG_EXPERT require
CONFIG_DEBUG_KERNEL, it doesn't apply for all features.
The meaning of CONFIG_EXPERT and CONFIG_DEBUG_KERNEL has been
mixed here.
It looks like CONFIG_KALLSYMS_ALL is the only feature that
requires CONFIG_DEBUG_KERNEL. Move the CONFIG_DEBUG_KERNEL
selection to where it really is needed.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
init/Kconfig | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
index 4592bf7997c0..0a6346feae8d 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1206,8 +1206,6 @@ config BPF
menuconfig EXPERT
bool "Configure standard kernel features (expert users)"
- # Unhide debug options, to make the on-by-default options visible
- select DEBUG_KERNEL
help
This option allows certain base kernel options and settings
to be disabled or tweaked. This is for specialized
@@ -1473,7 +1471,8 @@ config KALLSYMS
config KALLSYMS_ALL
bool "Include all symbols in kallsyms"
- depends on DEBUG_KERNEL && KALLSYMS
+ select DEBUG_KERNEL
+ depends on KALLSYMS
help
Normally kallsyms only contains the symbols of functions for nicer
OOPS messages and backtraces (i.e., symbols from the text and inittext
--
2.21.0
next reply other threads:[~2019-04-10 21:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 21:26 Sinan Kaya [this message]
2019-04-10 21:45 ` [PATCH v1] init: Do not select DEBUG_KERNEL by default Kees Cook
2019-04-10 21:53 ` Sinan Kaya
2019-04-10 22:04 ` Mathieu Desnoyers
2019-04-10 22:07 ` Kees Cook
2019-04-10 22:04 ` Kees Cook
2019-04-10 22:18 ` Sinan Kaya
2019-04-10 22:21 ` Kees Cook
2019-04-10 22:25 ` Sinan Kaya
2019-04-10 22:28 ` Kees Cook
2019-04-10 22:29 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410212627.29514-1-okaya@kernel.org \
--to=okaya@kernel.org \
--cc=adrian@lisas.de \
--cc=akpm@linux-foundation.org \
--cc=gor@linux.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=rgb@redhat.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox