From: Mao Han <han_mao@c-sky.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] perf: use hweight64 instead of hweight_long
Date: Thu, 11 Apr 2019 15:40:29 +0800 [thread overview]
Message-ID: <20190411074024.GA8981@vmh-VirtualBox> (raw)
In-Reply-To: <20190410132837.GG13888@kernel.org>
On Wed, Apr 10, 2019 at 10:28:37AM -0300, Arnaldo Carvalho de Melo wrote:
> > > You forgot to convert that one, doing it for you,
> >
> > Also in perf_event__sample_event_size() we need to do the same thing,
> > right?
>
> and perf_event__synthesize_sample()
>
> Done, resulting patch is at the end of this messages, and matches the
> kernel, that uses only hweight64().
>
> I've also added Fixes tags to the patches that used hweight_long() in
> various places, to help with the stable trees backporting process,
> please consider doing it next time.
>
> - Arnaldo
>
Thanks for help improving the patch and the suggestion.
Tested with the new patch on C-SKY, seems work fine.
Mao Han
next prev parent reply other threads:[~2019-04-11 7:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 8:16 [PATCH v3 0/3] csky: perf callchain dwarf support Mao Han
2019-04-10 8:16 ` [PATCH v3 1/3] perf: use hweight64 instead of hweight_long Mao Han
2019-04-10 13:08 ` Arnaldo Carvalho de Melo
2019-04-10 13:10 ` Arnaldo Carvalho de Melo
2019-04-10 13:28 ` Arnaldo Carvalho de Melo
2019-04-11 7:40 ` Mao Han [this message]
2019-04-12 16:40 ` [tip:perf/urgent] perf evsel: Use hweight64() instead of hweight_long(attr.sample_regs_user) tip-bot for Mao Han
2019-04-16 15:30 ` tip-bot for Mao Han
2019-04-10 8:16 ` [PATCH v3 2/3] csky: Add support for perf registers sampling Mao Han
2019-04-10 8:16 ` [PATCH v3 3/3] csky: add support for libdw Mao Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411074024.GA8981@vmh-VirtualBox \
--to=han_mao@c-sky.com \
--cc=arnaldo.melo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox