From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A8B2C10F13 for ; Thu, 11 Apr 2019 16:49:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39EB42133D for ; Thu, 11 Apr 2019 16:49:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727059AbfDKQtl (ORCPT ); Thu, 11 Apr 2019 12:49:41 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:46220 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726676AbfDKQtk (ORCPT ); Thu, 11 Apr 2019 12:49:40 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 50221374; Thu, 11 Apr 2019 09:49:40 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C74633F59C; Thu, 11 Apr 2019 09:49:38 -0700 (PDT) Date: Thu, 11 Apr 2019 17:49:36 +0100 From: Sudeep Holla To: "Koskinen, Aaro (Nokia - FI/Espoo)" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Aaro Koskinen , Florian Fainelli , Michal Simek , Mark Rutland , Lorenzo Pieralisi Subject: Re: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2 Message-ID: <20190411164936.GB5327@e107155-lin> References: <20190411103346.22462-1-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 11, 2019 at 11:42:28AM +0000, Koskinen, Aaro (Nokia - FI/Espoo) wrote: > Hi, > > From: Sudeep Holla [sudeep.holla@arm.com]: > > static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd) > > { > > + if ((reboot_mode == REBOOT_WARM || reboot_mode == REBOOT_SOFT) && > > I would omit the REBOOT_SOFT here. > I included REBOOT_SOFT for 2 reasons: 1. drivers/firmware/efi/reboot.c - efi_reboot treats WARM and SOFT reboots same 2. If the vendors specific reboots are added and handled in EFI, I assume it will be categorised under REBOOT_SOFT. If that's wrong I can drop REBOOT_SOFT. > > + psci_system_reset2_supported) > > + /* > > + * reset_type[31] = 0 (architectural) > > + * reset_type[30:0] = 0 (SYSTEM_WARM_RESET) > > + * cookie = 0 (ignored by the implementation) > > + */ > > + invoke_psci_fn(PSCI_FN_NATIVE(1_1, SYSTEM_RESET2), 0, 0, 0); > > + > > invoke_psci_fn(PSCI_0_2_FN_SYSTEM_RESET, 0, 0, 0); > > Use else here, so that we fall back to system halt if SYSTEM_RESET2 fails. > Will that not change current behaviour ? IOW, is that expected behaviour ? I am not sure if halt can be prefer over cold reboot in absence of warm/soft reboot when the system is request to reboot. From PSCI perspective, since SYSTEM_RESET is mandatory I prefer that unless Linux has any restriction on this behaviour. -- Regards, Sudeep