From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC64C10F13 for ; Thu, 11 Apr 2019 22:17:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91A6F2146F for ; Thu, 11 Apr 2019 22:17:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726837AbfDKWQ7 (ORCPT ); Thu, 11 Apr 2019 18:16:59 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:38893 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726640AbfDKWQ7 (ORCPT ); Thu, 11 Apr 2019 18:16:59 -0400 Received: from localhost (unknown [134.134.139.76]) (Authenticated sender: josh@joshtriplett.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 708DA20000A; Thu, 11 Apr 2019 22:16:48 +0000 (UTC) Date: Thu, 11 Apr 2019 15:16:45 -0700 From: Josh Triplett To: Sinan Kaya Cc: Kees Cook , LKML , Masahiro Yamada , Andrew Morton , "Peter Zijlstra (Intel)" , Johannes Weiner , Nicholas Piggin , Mathieu Desnoyers , Vasily Gorbik , Adrian Reber , Richard Guy Briggs , Petr Mladek , Andy Shevchenko , Matthew Wilcox , Joe Lawrence , Randy Dunlap , Mikulas Patocka , Robin Murphy , Tetsuo Handa , Changbin Du , Frederic Weisbecker , Sam Ravnborg , Ingo Molnar Subject: Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default Message-ID: <20190411221645.GA8692@localhost> References: <20190410224213.20651-1-okaya@kernel.org> <135E84E9-F068-44CB-B4F6-A5AC2F4CDE3D@joshtriplett.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 10, 2019 at 11:13:52PM -0400, Sinan Kaya wrote: > On 4/10/2019 11:02 PM, Josh Triplett wrote: > > Then let's fix*that*, and get checkpatch to help enforce it in the future. EXPERT doesn't affect code generation, and neither should this. > > I think we have to do both. We need to go after the users as well as > solve the immediate problem per this patch. > > As Mathieu identified, CONFIG_DEBUG_KERNEL is being used all over the > place and getting subsystem owners to remove let alone add a check > to checkpatch is just going to take time. > > Please let us know if you are OK with this plan. I'm not OK with this plan. Turning on EXPERT should make the options under DEBUG_KERNEL visible; it's a bug that DEBUG_KERNEL affects code generation as well. Proposed alternative plan: let's add a new symbol, something like DEBUG_MISC ("Miscellaneous debug code that should be under a more specific debug option but isn't"), make it depend on DEBUG_KERNEL and be "default DEBUG_KERNEL" but allow itself to be turned off, and then mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to "#ifdef CONFIG_DEBUG_MISC". Does that sound like an appropriately rapid solution for this bug?