public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Sinan Kaya <okaya@kernel.org>
Cc: linux-kernel@vger.kernel.org, keescook@chromium.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Petr Mladek <pmladek@suse.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Matthew Wilcox <willy@infradead.org>,
	Joe Lawrence <joe.lawrence@redhat.com>,
	Mikulas Patocka <mpatocka@redhat.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Sri Krishna chowdary <schowdary@nvidia.com>,
	Changbin Du <changbin.du@intel.com>
Subject: Re: [PATCH v4 1/5] init: Introduce DEBUG_MISC option
Date: Thu, 11 Apr 2019 20:01:12 -0700	[thread overview]
Message-ID: <20190412030111.GA1577@localhost> (raw)
In-Reply-To: <20190412014355.25307-2-okaya@kernel.org>

On Fri, Apr 12, 2019 at 01:43:51AM +0000, Sinan Kaya wrote:
> Introduce DEBUG_MISC ("Miscellaneous debug code that should be under a more
> specific debug option but isn't"), make it depend on DEBUG_KERNEL and be
> "default DEBUG_KERNEL" but allow itself to be turned off, and then
> mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to
> "#ifdef CONFIG_DEBUG_MISC".
> 
> Signed-off-by: Sinan Kaya <okaya@kernel.org>

Minor typo below; with that:
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

And thank you!

> ---
>  lib/Kconfig.debug | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 0d9e81779e37..2f80ebaa6d9a 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -438,6 +438,15 @@ config DEBUG_KERNEL
>  	  Say Y here if you are developing drivers or trying to debug and
>  	  identify kernel problems.
>  
> +config DEBUG_MISC
> +	bool "Miscellaneous debug code"
> +	default DEBUG_KERNEL
> +	depends on DEBUG_KERNEL
> +	help
> +	  Say Y here if you need to enable Miscellaneous debug code that should

Nit: s/Miscellaneous/miscellaneous/

> +	  be under a more specific debug option but isn't.
> +
> +
>  menu "Memory Debugging"
>  
>  source "mm/Kconfig.debug"
> -- 
> 2.21.0
> 

  reply	other threads:[~2019-04-12  3:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12  1:43 [PATCH v4 0/5] init: Do not select DEBUG_KERNEL by default Sinan Kaya
2019-04-12  1:43 ` [PATCH v4 1/5] init: Introduce DEBUG_MISC option Sinan Kaya
2019-04-12  3:01   ` Josh Triplett [this message]
2019-04-12  1:43 ` [PATCH v4 2/5] powerpc: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC Sinan Kaya
2019-04-12  1:43 ` [PATCH v4 3/5] mips: " Sinan Kaya
2019-04-12  1:43 ` [PATCH v4 4/5] xtensa: " Sinan Kaya
2019-04-12  1:43 ` [PATCH v4 5/5] net: " Sinan Kaya
2019-04-12  8:09   ` Florian Westphal
2019-04-12  3:02 ` [PATCH v4 0/5] init: Do not select DEBUG_KERNEL by default Josh Triplett
2019-04-12  3:13   ` Sinan Kaya
2019-04-12  4:05     ` Josh Triplett
2019-04-12  4:06       ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190412030111.GA1577@localhost \
    --to=josh@joshtriplett.org \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=changbin.du@intel.com \
    --cc=joe.lawrence@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=okaya@kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=pmladek@suse.com \
    --cc=robin.murphy@arm.com \
    --cc=schowdary@nvidia.com \
    --cc=willy@infradead.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox