public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	vkoul@kernel.org, gregkh@linuxfoundation.org,
	liam.r.girdwood@linux.intel.com, jank@cadence.com,
	joe@perches.com, srinivas.kandagatla@linaro.org,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 1/2] regmap: soundwire: fix Kconfig select/depend issue
Date: Fri, 12 Apr 2019 09:46:16 +0100	[thread overview]
Message-ID: <20190412084616.GC6909@sirena.org.uk> (raw)
In-Reply-To: <s5ho95bpqis.wl-tiwai@suse.de>

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

On Fri, Apr 12, 2019 at 10:38:19AM +0200, Takashi Iwai wrote:
> Pierre-Louis Bossart wrote:

> > config REGMAP_SOUNDWIRE
> >        depends on SOUNDWIRE
> >        select SOUNDWIRE_BUS

> To be noted, in general you can't do put both depends-on and select.
> The select always wins.  So the depends-on in REGMAP_SOUNDWIRE is more
> or less moot.

To be clear the issue is that the dependencies of selected symbols just
get ignored (IIRC their selects too).  It can be useful for
documentation but it does get a bit confusing sometimes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-04-12  8:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 19:28 [PATCH 0/2] soundwire: fix Kconfig select/depend issues Pierre-Louis Bossart
2019-04-11 19:28 ` [PATCH 1/2] regmap: soundwire: fix Kconfig select/depend issue Pierre-Louis Bossart
2019-04-12  8:38   ` Takashi Iwai
2019-04-12  8:46     ` Mark Brown [this message]
2019-04-12 14:07     ` [alsa-devel] " Pierre-Louis Bossart
2019-04-12 14:18       ` Mark Brown
2019-04-12 14:21         ` Takashi Iwai
2019-04-14 10:20           ` Vinod Koul
2019-04-11 19:28 ` [PATCH 2/2] soundwire: fix SOUNDWIRE_BUS option Pierre-Louis Bossart
2019-04-12 10:06 ` [PATCH 0/2] soundwire: fix Kconfig select/depend issues Srinivas Kandagatla
2019-04-12 14:17   ` [alsa-devel] " Pierre-Louis Bossart
2019-04-12 14:27     ` Mark Brown
2019-04-12 14:56       ` Pierre-Louis Bossart
2019-04-14 10:13 ` Vinod Koul
2019-04-15 12:50   ` [alsa-devel] " Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190412084616.GC6909@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jank@cadence.com \
    --cc=joe@perches.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rafael@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox