From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE30EC10F0E for ; Fri, 12 Apr 2019 15:40:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7EAB721872 for ; Fri, 12 Apr 2019 15:40:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726983AbfDLPkz (ORCPT ); Fri, 12 Apr 2019 11:40:55 -0400 Received: from muru.com ([72.249.23.125]:45624 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726711AbfDLPky (ORCPT ); Fri, 12 Apr 2019 11:40:54 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 84B4A80F3; Fri, 12 Apr 2019 15:41:09 +0000 (UTC) Date: Fri, 12 Apr 2019 08:40:51 -0700 From: Tony Lindgren To: Nathan Chancellor Cc: Daniel Lezcano , Ladislav Michl , Thomas Gleixner , linux-kernel@vger.kernel.org, YueHaibing , Keerthy Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start Message-ID: <20190412154051.GW2839@atomide.com> References: <20190327050126.12064-1-natechancellor@gmail.com> <20190327081142.GA11034@lenoch> <20190404141730.GE49658@atomide.com> <6defcea8-1e94-14ac-f9c5-e14c61ea4d99@linaro.org> <20190410200748.GN2839@atomide.com> <20190411205657.GT2839@atomide.com> <20190412045954.GA30291@archlinux-i9> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190412045954.GA30291@archlinux-i9> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Nathan Chancellor [190412 05:00]: > On Thu, Apr 11, 2019 at 01:56:57PM -0700, Tony Lindgren wrote: > > Hi, > > > > * Daniel Lezcano [190411 19:21]: > > > On 10/04/2019 22:07, Tony Lindgren wrote: > > > > Hi, > > > > > > > > * Daniel Lezcano [190410 17:02]: > > > >> can you ask for an acked-by before pulling a patch in your tree? > > > > > > > > I certainly do ask and wait for acks where possible :) > > > > > > Ok, I may have missed them. > > > > > > > Note that I have not applied this patch. I just added > > > > Keerthy to Cc on this thread so maybe you misread the > > > > message earlier. My comment "seems like no other > > > > takers" was for Ladislav regarding somebody picking up > > > > his earlier work, not for picking up this patch :) > > > > > > Actually I was referring to the commit 592ea6bd1fad. Anyway as stated > > > above I could have miss your call. > > > > Hmm so commit 592ea6bd1fad was part of the PWM timer series > > that was posted several times from late 2017 to end of > > February 2018. I did not get any timer related acks or > > comments so I applied it together with the PWM timer > > changes. > > > > I'm guessing you may have accidentally checked out some > > older deja-vu branch from about a year ago? Commit > > 592ea6bd1fad is not related to this fix.. :) > > > > Just for the record, I said this patch fixes 592ea6bd1fad because > 592ea6bd1fad should have been marked this function as static, which > would have exposed that this function was unused and it could have > been removed at that time. I know it is a bit of a stretch for this > commit (would be more appropriate for 008258d995a6 to have it) but > that was my logic behind it. Not opposed to having it removed before > committing. Oh OK yes they should have all become static with the PWM series. Regards, Tony