From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAF9BC10F0E for ; Fri, 12 Apr 2019 19:56:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79B70218A3 for ; Fri, 12 Apr 2019 19:56:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555099011; bh=8smsSmoLiGCLUxSbLuqgD3317huQyh2jmer/5G9rRJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mcaKHCq6B7apKUFpbuA6Jeet+eHdzXd3yEnoczziu2GzPWnRklUb8y64BYZdAYBr0 caNnaN819VAOnG3KPV+yI1hwP1Jy1jZNj/hC4Jfp52rSvD0bZUlLyOehnnvT76AHXV qg+0RdEdbAApultQ3U/Ha3kWBdSpHI7jjW9tOvkw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727048AbfDLT4u (ORCPT ); Fri, 12 Apr 2019 15:56:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:56256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726832AbfDLT4t (ORCPT ); Fri, 12 Apr 2019 15:56:49 -0400 Received: from localhost (unknown [77.138.135.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2FEDB2171F; Fri, 12 Apr 2019 19:56:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555099008; bh=8smsSmoLiGCLUxSbLuqgD3317huQyh2jmer/5G9rRJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W4QXNx7rH+AgjDiyq67un/ItT2S90Bubp0H4mMJkzZptUo1SyhWlLXAU3ieLvJBbr rXoRI/3nJvl/2a1dW3YckUzgAK3seS48OaTiOEGQSh33FTap6oi55Mg+T+h0PyC9Bn gIkQqFwLDWr4U/u9CISX7KVKgpXsGvuMTyG7NpuE= Date: Fri, 12 Apr 2019 22:56:45 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: Parav Pandit , Doug Ledford , Steve Wise , =?iso-8859-1?Q?H=E5kon?= Bugge , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] RDMA/cma: Make CM response timeout and # CM retries configurable Message-ID: <20190412195645.GG3201@mtr-leonro.mtl.com> References: <20190217170909.1178575-1-haakon.bugge@oracle.com> <20190222163637.GA9819@ziepe.ca> <20190223084930.GJ23561@mtr-leonro.mtl.com> <20190412193024.GB4690@ziepe.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1ddnCX6roxAgyKJ1" Content-Disposition: inline In-Reply-To: <20190412193024.GB4690@ziepe.ca> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1ddnCX6roxAgyKJ1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 12, 2019 at 04:30:24PM -0300, Jason Gunthorpe wrote: > On Mon, Mar 04, 2019 at 06:27:26AM +0000, Parav Pandit wrote: > > > I think we should use rdma_nl_register(RDMA_NL_RDMA_CM, cma_cb_table) which was removed as part of ID stats removal. > > Because of below reasons. > > 1. rdma netlink command auto loads the module > > This is probably the best argument to stay away from sysctl for module > parameters.. It is tricky to make sure the rdma module is loaded > before sysctl runs in boot, and I don't think sysctl autoloads missing > modules, or somehow copes with dynamic module loading, does it? As far as I remember, sysctl won't be available till module is loaded, so autoload won't work because path doesn't exist. > > To that end we should probably have the entire sysctl configurable > available in netlink > > Jason --1ddnCX6roxAgyKJ1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJcsO19AAoJEORje4g2clinAIgP/3fDJ2ejyqJ3RWUKefRTl98A a9xElmkzfHyU5J6wnDPyBqssKwrzz9MCcIXvDPFI55SpoYNVYjmW0HpFOAfZtfF3 Wz6psZh6NqfNUvkkG9h0pGyDgZl/OADpEYNV0Gv1dR5mpM4uTWMYLEBkHoxrTMji RuA5sueapLvADXUMemD//SiAgLsM3Jckarto0mPfp52sq9Pt41utGjlq4yN+mcXt Mbz3rQw2Ey5/6gxTr4IvXWDOdOHRkLSpYon06m1PfJPgjhIX+IbxSNbKI9P1l+Xz m0pRB1mR+7pKGuUzpKZC6WilOab1v0CYaBFpzLOaGL/RwMGUhFjSLI2SO0ecfVD2 fFFY2V7TH9DInTSrHDIcqFlJNYfUd6zmj0QXZ+e6yP8HybkhBgahDF87dbniRrLj QP/A30ouCVm3oGkS5KuV5ZNL/JusWpFhL48pzqZgEyEZ9F0Px2ILa/nhMUyOQJbr 5hPEwA9gaL8qXbodqphpXLHaBm3i2rL3EqpNdtbiDrFDVHDstLV6sek0/IKNTaiU EIRutsOTRFoXengQjv/ezKI5pVhjWLoGciVfa4uioiIObqw1YJymdF4qKXG6zQfd UK/SnWUudr8NyWzFkYK3IX0upw0hkGSGnYvLSU7TkfDbIma/uzPcDTEXYCYZv/Vl IGe2aZTyxCSckkYSurdy =RILM -----END PGP SIGNATURE----- --1ddnCX6roxAgyKJ1--