From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 758AFC10F0E for ; Sat, 13 Apr 2019 00:00:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41CC4218AF for ; Sat, 13 Apr 2019 00:00:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Hj2rdsYG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726997AbfDMAAC (ORCPT ); Fri, 12 Apr 2019 20:00:02 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:41164 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726925AbfDMAAB (ORCPT ); Fri, 12 Apr 2019 20:00:01 -0400 Received: by mail-pl1-f193.google.com with SMTP id d1so5843150plj.8 for ; Fri, 12 Apr 2019 17:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bbs5HfQR8f9fFhny2Ldk4rVmZ4ck6fsnGnctynUeJJI=; b=Hj2rdsYGirEF7MWoO943LuyCyLbVApQG3+8mJE4FSamer4QZsl74O1Y7uCADeWXRGh mhQnjHa0nBVOFVAaXrTb+uimDfXoia+qCrUMyteltw4onb6WToGEWYck7B9pBnTbKXgp h43XFw3CjDawZy4CLT6zQfnxvAkQSkJk2cH8s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bbs5HfQR8f9fFhny2Ldk4rVmZ4ck6fsnGnctynUeJJI=; b=mCBme0ttHPnCgjX43VhXXLMXHPyEG52oAbzNrR0hRJoDBqBaLxARwBFJamEFCfK7PY BVtAMvphlNO855ZfO0kvqYvOgr41yx40NlYC4l7Y8y9Up3tAgKGLE6B1IAUG3cbW/K6s Z+NtmhBVjSrAZoFDDzzGuciBDZfppo9Tkw2hE7cvE132G1wjFjT17amCd0CkvzAuumdX Il30M3C7Fsy32C2ml89+pbtdd4VdZgv2LaAXdocF/jU6AkefDNP4Dl6onvLpvAbcSY7b dZ7vJXp+zIXqv1Sda50KAVzztN7Pa+7BnXXsCp/FKR+uy5d8w0V5JTLXh8ApaTOWXOWc AhxA== X-Gm-Message-State: APjAAAXnyRRYWiIapzl4IPiexhycSE8DtBNt3EPPXypgCClWRvbE97T0 b8UwPLGCnUcZl02tB1UTzis2Dw== X-Google-Smtp-Source: APXvYqxAK/W0boE3DYtmzFZCw7qH3Q53NJtfyhzCZQvQVzXa2qcfypGjOXHMbqIP1lyiF9xRexKdfw== X-Received: by 2002:a17:902:d211:: with SMTP id t17mr58439284ply.214.1555113601260; Fri, 12 Apr 2019 17:00:01 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id m16sm104908447pfi.29.2019.04.12.17.00.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Apr 2019 17:00:00 -0700 (PDT) Date: Fri, 12 Apr 2019 17:00:00 -0700 From: Matthias Kaehlcke To: Douglas Anderson Cc: Rob Herring , Minas Harutyunyan , Heiko Stuebner , Felipe Balbi , amstan@chromium.org, linux-rockchip@lists.infradead.org, linux-usb@vger.kernel.org, Randy Li , ryandcase@chromium.org, jwerner@chromium.org, Elaine Zhang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/4] ARM: dts: rockchip: Hook resets up to USB PHYs on rk3288. Message-ID: <20190413000000.GA112750@google.com> References: <20190412224149.106971-1-dianders@chromium.org> <20190412224149.106971-4-dianders@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190412224149.106971-4-dianders@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 12, 2019 at 03:41:48PM -0700, Douglas Anderson wrote: > Let's hook up the resets to the three USB PHYs on rk3288 as per the > bindings. This is in preparation for a future patch that will set the > "snps,reset-phy-on-wake" on the host port. > > Signed-off-by: Douglas Anderson > --- > > arch/arm/boot/dts/rk3288.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index 2e604f0afa98..92e0600595f8 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -905,6 +905,8 @@ > clocks = <&cru SCLK_OTGPHY0>; > clock-names = "phyclk"; > #clock-cells = <0>; > + resets = <&cru SRST_USBOTG_PHY>; > + reset-names = "phy-reset"; > }; > > usbphy1: usb-phy@334 { > @@ -913,6 +915,8 @@ > clocks = <&cru SCLK_OTGPHY1>; > clock-names = "phyclk"; > #clock-cells = <0>; > + resets = <&cru SRST_USBHOST0_PHY>; > + reset-names = "phy-reset"; > }; > > usbphy2: usb-phy@348 { > @@ -921,6 +925,8 @@ > clocks = <&cru SCLK_OTGPHY2>; > clock-names = "phyclk"; > #clock-cells = <0>; > + resets = <&cru SRST_USBHOST1_PHY>; > + reset-names = "phy-reset"; > }; > }; > }; Reviewed-by: Matthias Kaehlcke