From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org,
liam.r.girdwood@linux.intel.com, jank@cadence.com,
joe@perches.com, srinivas.kandagatla@linaro.org
Subject: Re: [PATCH v3 0/5] soundwire: code cleanup
Date: Sun, 14 Apr 2019 15:34:17 +0530 [thread overview]
Message-ID: <20190414100417.GH28103@vkoul-mobl> (raw)
In-Reply-To: <20190411031701.5926-1-pierre-louis.bossart@linux.intel.com>
On 10-04-19, 22:16, Pierre-Louis Bossart wrote:
> SoundWire support will be provided in Linux with the Sound Open
> Firmware (SOF) on Intel platforms. Before we start adding the missing
> pieces, there are a number of warnings and style issues reported by
> checkpatch, cppcheck and Coccinelle that need to be cleaned-up.
Applied, 1, 3 and 4 (5 looked good but didnt apply)
Thanks
>
> Changes since v2:
> fixed inversion of devm_kcalloc parameters, detected while rebasing
> additional patches.
>
> Changes since v1:
> added missing newlines in new patch (suggested by Joe Perches)
>
> Pierre-Louis Bossart (5):
> soundwire: intel: fix inversion in devm_kcalloc parameters
> soundwire: fix style issues
> soundwire: bus: remove useless initializations
> soundwire: stream: remove useless initialization of local variable
> soundwire: add missing newlines in dynamic debug logs
>
> drivers/soundwire/Kconfig | 2 +-
> drivers/soundwire/bus.c | 137 ++++++++-------
> drivers/soundwire/bus.h | 16 +-
> drivers/soundwire/bus_type.c | 4 +-
> drivers/soundwire/cadence_master.c | 99 +++++------
> drivers/soundwire/cadence_master.h | 22 +--
> drivers/soundwire/intel.c | 103 ++++++-----
> drivers/soundwire/intel.h | 4 +-
> drivers/soundwire/intel_init.c | 12 +-
> drivers/soundwire/mipi_disco.c | 116 +++++++------
> drivers/soundwire/slave.c | 10 +-
> drivers/soundwire/stream.c | 267 +++++++++++++++--------------
> 12 files changed, 404 insertions(+), 388 deletions(-)
>
> --
> 2.17.1
--
~Vinod
next prev parent reply other threads:[~2019-04-14 10:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 3:16 [PATCH v3 0/5] soundwire: code cleanup Pierre-Louis Bossart
2019-04-11 3:16 ` [PATCH v3 1/5] soundwire: intel: fix inversion in devm_kcalloc parameters Pierre-Louis Bossart
2019-04-11 8:43 ` Takashi Iwai
2019-04-11 3:16 ` [PATCH v3 2/5] soundwire: fix style issues Pierre-Louis Bossart
2019-04-14 9:58 ` Vinod Koul
2019-04-15 13:09 ` [alsa-devel] " Pierre-Louis Bossart
2019-04-17 9:33 ` Johan Hovold
2019-04-17 17:18 ` Pierre-Louis Bossart
2019-04-18 17:29 ` Johan Hovold
2019-04-19 17:14 ` Pierre-Louis Bossart
2019-04-30 8:57 ` Vinod Koul
2019-04-30 8:51 ` Vinod Koul
2019-04-30 13:38 ` Pierre-Louis Bossart
2019-04-30 14:05 ` Greg KH
2019-04-30 14:13 ` Pierre-Louis Bossart
2019-04-30 14:25 ` Greg KH
[not found] ` <20190430145444.GU3845@vkoul-mobl.Dlink>
2019-04-30 16:29 ` Pierre-Louis Bossart
2019-04-11 3:16 ` [PATCH v3 3/5] soundwire: bus: remove useless initializations Pierre-Louis Bossart
2019-04-11 3:17 ` [PATCH v3 4/5] soundwire: stream: remove useless initialization of local variable Pierre-Louis Bossart
2019-04-11 3:17 ` [PATCH v3 5/5] soundwire: add missing newlines in dynamic debug logs Pierre-Louis Bossart
2019-04-11 8:43 ` [PATCH v3 0/5] soundwire: code cleanup Takashi Iwai
2019-04-14 10:04 ` Vinod Koul [this message]
2019-04-15 12:57 ` [alsa-devel] " Pierre-Louis Bossart
2019-04-19 17:07 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190414100417.GH28103@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=joe@perches.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox