From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE2EC10F0E for ; Mon, 15 Apr 2019 06:23:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CD1B2073F for ; Mon, 15 Apr 2019 06:23:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UmlWx3EC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726190AbfDOGXV (ORCPT ); Mon, 15 Apr 2019 02:23:21 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:33522 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbfDOGXU (ORCPT ); Mon, 15 Apr 2019 02:23:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iMYvlJpOrmIaz66/RQF0yiu3LcjskOwFEGg5wuRgYJc=; b=UmlWx3ECj6cKii7VP6bnwCOzR j83NHFXEHCFg6N2pyMLk4bokn0Go/t76c6Wh7ez3g6xwmMrXddZNEOzpBhyL1/86AMTcR2uQKvcRk kapWU2N1ipqvngznoNLR6shJ9N1QDSayD4GwEKPFp1eJh7T6xeFh/DlJOc20L7o/ESHbyxsYB/hGb Y3v4y9DsR2b/U2+6NdCqaC68KL0e2bG255kD09E4jBqUbh7BAko2uKlkSxLMztvT/RbQohYM7qUhy fyRDbDITT6rzDrD5JbVLoJzuwaQdL1nRPO70a/8g+3eyJIupU5hwBD3wDo4KRXcDrzuxkh8uFDDY7 a9jyIkhnw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFv1Q-00077e-Qo; Mon, 15 Apr 2019 06:23:16 +0000 Date: Sun, 14 Apr 2019 23:23:16 -0700 From: Christoph Hellwig To: Tom Murphy Cc: iommu@lists.linux-foundation.org, Heiko Stuebner , Will Deacon , David Brown , linux-samsung-soc@vger.kernel.org, dima@arista.com, Krzysztof Kozlowski , linux-rockchip@lists.infradead.org, Kukjin Kim , Andy Gross , Marc Zyngier , linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, murphyt7@tcd.ie, Robin Murphy Subject: Re: [PATCH 9/9] iommu/amd: Add allocated domain to global list earlier Message-ID: <20190415062316.GC18154@infradead.org> References: <20190411184741.27540-1-tmurphy@arista.com> <20190411184741.27540-10-tmurphy@arista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190411184741.27540-10-tmurphy@arista.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 11, 2019 at 07:47:38PM +0100, Tom Murphy via iommu wrote: > dma_ops_domain_free() expects domain to be in a global list. > Arguably, could be called before protection_domain_init(). > > Signed-off-by: Dmitry Safonov > Signed-off-by: Tom Murphy This seems like a fix to the existing code and should probably go out first.