From: Johan Hovold <johan@kernel.org>
To: Will Cunningham <wjcunningham7@gmail.com>
Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: greybus: usb: Fixed a coding style error
Date: Mon, 15 Apr 2019 14:42:50 +0200 [thread overview]
Message-ID: <20190415124250.GA775@localhost> (raw)
In-Reply-To: <20190331053040.GA12974@titus.pi.local>
On Sun, Mar 31, 2019 at 01:30:40AM -0400, Will Cunningham wrote:
> Line was >80 characters.
>
> Signed-off-by: Will Cunningham <wjcunningham7@gmail.com>
> ---
> drivers/staging/greybus/usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c
> index 1c246c73a085..5b4cbec88159 100644
> --- a/drivers/staging/greybus/usb.c
> +++ b/drivers/staging/greybus/usb.c
> @@ -169,8 +169,8 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev,
> return -ENOMEM;
>
> connection = gb_connection_create(gbphy_dev->bundle,
> - le16_to_cpu(gbphy_dev->cport_desc->id),
> - NULL);
> + le16_to_cpu(gbphy_dev->cport_desc->id),
> + NULL);
As others have already pointed out in this thread, there's no need to
fix anything here.
The 80 column rule is not absolute in any way, and having a line be 81
characters if that improves readability is just fine.
Johan
prev parent reply other threads:[~2019-04-15 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 5:30 [PATCH] Staging: greybus: usb: Fixed a coding style error Will Cunningham
2019-03-31 6:04 ` Joe Perches
2019-03-31 6:20 ` [greybus-dev] " Alex Elder
2019-03-31 6:40 ` Joe Perches
2019-03-31 6:43 ` Alex Elder
2019-04-15 12:42 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415124250.GA775@localhost \
--to=johan@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wjcunningham7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox