From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE611C10F0E for ; Mon, 15 Apr 2019 14:03:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F09E2087C for ; Mon, 15 Apr 2019 14:03:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727508AbfDOODK (ORCPT ); Mon, 15 Apr 2019 10:03:10 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:41125 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727025AbfDOODJ (ORCPT ); Mon, 15 Apr 2019 10:03:09 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id F07AE80898; Mon, 15 Apr 2019 16:02:57 +0200 (CEST) Date: Mon, 15 Apr 2019 16:03:06 +0200 From: Pavel Machek To: Dan Murphy Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH 5/5] leds: lm3697: Introduce the lm3697 driver Message-ID: <20190415140306.GA13084@amd> References: <20190325142403.30447-1-dmurphy@ti.com> <20190325142403.30447-6-dmurphy@ti.com> <20190413200605.GA3013@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > >> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > >> index 735009e73414..688bb9a6f275 100644 > >> --- a/drivers/leds/Kconfig > >> +++ b/drivers/leds/Kconfig > >> @@ -776,9 +776,15 @@ config LEDS_NIC78BX > >> To compile this driver as a module, choose M here: the module > >> will be called leds-nic78bx. > >> =20 > >> +config LEDS_LM3697 > >> + tristate "LED driver for LM3697" > >> + depends on LEDS_TI_LMU_COMMON > >> + help > >> + Say Y to enable the LM3697 LED driver for TI LMU devices. > >> + This supports the LED device LM3697. > >> + > >> config LEDS_TI_LMU_COMMON > >> tristate "LED driver for TI LMU" > >> - depends on REGMAP > >> help > >> Say Y to enable the LED driver for TI LMU devices. > >> This supports common features between the TI LM3532, LM3631= , LM3632, =2E.. > > Plus we'd normally expect "COMMON" first and then specific driver. Not > > sure if Kconfig can handle it out-of-order... >=20 > OK. Should I rename the ti_lmu file to leds-common-ti-lmu? Oh, no, that is not what I meant. You have config B depends on A config A above. We really want config A config B depends on A > This keeps the naming convention the same in the leds directory as well. >=20 > FYI I will not add your acked-by on the LMU patch that introduced the cod= e unless you approve. > Since you found issues with the kconfig I did not review it in great detail, so no acked-by's, yet :-). Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAly0jxkACgkQMOfwapXb+vITrQCdHUFgkRNr0jijvWO/hgXaEbue eqoAnjr1VJSXdiyqH/OpCmSVu22z7g0B =r85c -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--