From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: [PATCH v2 03/19] PM / devfreq: tegra: Don't ignore clk errors
Date: Mon, 15 Apr 2019 17:54:49 +0300 [thread overview]
Message-ID: <20190415145505.18397-4-digetx@gmail.com> (raw)
In-Reply-To: <20190415145505.18397-1-digetx@gmail.com>
The clk_set_min_rate() could fail and in this case clk_set_rate() sets
rate to 0, which may drop EMC rate to minimum and make machine very
difficult to use.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/devfreq/tegra-devfreq.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
index 0c0909fba545..69581c9082d4 100644
--- a/drivers/devfreq/tegra-devfreq.c
+++ b/drivers/devfreq/tegra-devfreq.c
@@ -487,6 +487,7 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
struct tegra_devfreq *tegra = dev_get_drvdata(dev);
struct dev_pm_opp *opp;
unsigned long rate;
+ int err;
opp = devfreq_recommended_opp(dev, freq, flags);
if (IS_ERR(opp)) {
@@ -496,8 +497,13 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
rate = dev_pm_opp_get_freq(opp);
dev_pm_opp_put(opp);
- clk_set_min_rate(tegra->emc_clock, rate);
- clk_set_rate(tegra->emc_clock, 0);
+ err = clk_set_min_rate(tegra->emc_clock, rate);
+ if (err)
+ return err;
+
+ err = clk_set_rate(tegra->emc_clock, 0);
+ if (err)
+ return err;
return 0;
}
--
2.21.0
next prev parent reply other threads:[~2019-04-15 14:58 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 14:54 [PATCH v2 00/19] NVIDIA Tegra devfreq improvements and Tegra20/30 support Dmitry Osipenko
2019-04-15 14:54 ` [PATCH v2 01/19] PM / devfreq: tegra: Fix kHz to Hz conversion Dmitry Osipenko
2019-04-16 1:45 ` Chanwoo Choi
2019-04-16 13:24 ` Dmitry Osipenko
2019-04-15 14:54 ` [PATCH v2 02/19] PM / devfreq: tegra: Replace readl-writel with relaxed versions Dmitry Osipenko
2019-04-17 1:02 ` Chanwoo Choi
2019-04-15 14:54 ` Dmitry Osipenko [this message]
2019-04-16 1:52 ` [PATCH v2 03/19] PM / devfreq: tegra: Don't ignore clk errors Chanwoo Choi
2019-04-16 13:42 ` Dmitry Osipenko
2019-04-15 14:54 ` [PATCH v2 04/19] PM / devfreq: tegra: Don't set EMC clock rate to maximum on probe Dmitry Osipenko
2019-04-16 1:59 ` Chanwoo Choi
2019-04-16 13:44 ` Dmitry Osipenko
2019-04-15 14:54 ` [PATCH v2 05/19] PM / devfreq: tegra: Replace write memory barrier with the read barrier Dmitry Osipenko
2019-04-16 8:00 ` Chanwoo Choi
2019-04-16 13:57 ` Dmitry Osipenko
2019-04-17 0:55 ` Chanwoo Choi
2019-04-15 14:54 ` [PATCH v2 06/19] PM / devfreq: tegra: Fix missed error checking on devfreq initialization failure Dmitry Osipenko
2019-04-16 2:32 ` Chanwoo Choi
2019-04-16 14:29 ` Dmitry Osipenko
2019-04-17 1:01 ` Chanwoo Choi
2019-04-15 14:54 ` [PATCH v2 07/19] PM / devfreq: tegra: Register clk notifier in the end of driver's probe Dmitry Osipenko
2019-04-15 14:54 ` [PATCH v2 08/19] PM / devfreq: tegra: Remove OPP entries on driver removal Dmitry Osipenko
2019-04-15 14:54 ` [PATCH v2 09/19] PM / devfreq: tegra: Change interrupt request order Dmitry Osipenko
2019-04-15 14:54 ` [PATCH v2 10/19] PM / devfreq: tegra: Drop primary interrupt handler Dmitry Osipenko
2019-04-16 5:56 ` Chanwoo Choi
2019-04-16 15:23 ` Dmitry Osipenko
2019-04-17 0:31 ` Chanwoo Choi
2019-04-15 14:54 ` [PATCH v2 11/19] PM / devfreq: tegra: De-initialize properly on driver's probe error Dmitry Osipenko
2019-04-16 6:21 ` Chanwoo Choi
2019-04-15 14:54 ` [PATCH v2 12/19] PM / devfreq: tegra: Avoid inconsistency of current frequency value Dmitry Osipenko
2019-04-16 7:15 ` Chanwoo Choi
2019-04-16 15:40 ` Dmitry Osipenko
2019-04-17 0:35 ` Chanwoo Choi
2019-04-15 14:54 ` [PATCH v2 13/19] PM / devfreq: tegra: Mark ACTMON's governor as immutable Dmitry Osipenko
2019-04-16 7:17 ` Chanwoo Choi
2019-04-15 14:55 ` [PATCH v2 14/19] PM / devfreq: tegra: Move governor registration to driver's probe Dmitry Osipenko
2019-04-16 7:30 ` Chanwoo Choi
2019-04-15 14:55 ` [PATCH v2 15/19] PM / devfreq: tegra: Synchronize IRQ after masking it in hardware Dmitry Osipenko
2019-04-16 7:41 ` Chanwoo Choi
2019-04-16 15:42 ` Dmitry Osipenko
2019-04-15 14:55 ` [PATCH v2 16/19] PM / devfreq: tegra: Reconfigure hardware on governor's restart Dmitry Osipenko
2019-04-15 14:55 ` [PATCH v2 17/19] PM / devfreq: tegra: Support Tegra30 Dmitry Osipenko
2019-04-16 7:48 ` Chanwoo Choi
2019-04-16 15:49 ` Dmitry Osipenko
2019-04-17 0:28 ` Chanwoo Choi
2019-04-15 14:55 ` [PATCH v2 18/19] PM / devfreq: tegra: Enable COMPILE_TEST for the driver Dmitry Osipenko
2019-04-16 7:43 ` Chanwoo Choi
2019-04-16 15:52 ` Dmitry Osipenko
2019-04-17 0:27 ` Chanwoo Choi
2019-04-15 14:55 ` [PATCH v2 19/19] PM / devfreq: Introduce driver for NVIDIA Tegra20 Dmitry Osipenko
2019-04-16 8:31 ` Chanwoo Choi
2019-04-16 16:11 ` Dmitry Osipenko
2019-04-17 0:26 ` Chanwoo Choi
2019-04-17 9:36 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415145505.18397-4-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=jonathanh@nvidia.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox