From: Corey Minyard <minyard@acm.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: avoid atomic_inc in exit function
Date: Mon, 15 Apr 2019 12:39:35 -0500 [thread overview]
Message-ID: <20190415173935.GE4121@minyard.net> (raw)
In-Reply-To: <20190415164022.GA32090@infradead.org>
On Mon, Apr 15, 2019 at 09:40:22AM -0700, Christoph Hellwig wrote:
> On Mon, Apr 15, 2019 at 05:55:00PM +0200, Arnd Bergmann wrote:
> > This causes a link failure on ARM in certain configurations,
> > when we reference each atomic operation from .alt.smp.init in
> > order to patch out atomics on non-SMP systems:
> >
> > `.exit.text' referenced in section `.alt.smp.init' of drivers/char/ipmi/ipmi_msghandler.o: defined in discarded section `.exit.text' of drivers/char/ipmi/ipmi_msghandler.o
> >
> > In this case, we can trivially replace the atomic_inc() with
> > an atomic_set() that has the same effect and does not require
> > a fixup.
>
> I'd rather fіx the arm section management. Using atomic in exit
> routines is perfectly valid, and it would seem odd to forbid it.
That was my first thought, too. It's kind of hard to believe that
the IPMI driver is the only thing that does an atomic_inc() in the
exit code.
-corey
next prev parent reply other threads:[~2019-04-15 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 15:55 [PATCH] ipmi: avoid atomic_inc in exit function Arnd Bergmann
2019-04-15 16:40 ` Christoph Hellwig
2019-04-15 17:39 ` Corey Minyard [this message]
2019-04-15 19:00 ` Arnd Bergmann
2019-04-16 12:46 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415173935.GE4121@minyard.net \
--to=minyard@acm.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox