Re: [PATCH 1/3] remap: Add I3C bus support

Mark Brown
2019-04-16T15:40:03Z

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

On Mon, Apr 15, 2019 at 09:19:39PM +0200, Vitor Soares wrote:

> +++ b/drivers/base/regmap/regmap-i3c.c
> @@ -0,0 +1,62 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.

Please make the entire header C++ style so it looks more consistent.
Otherwise this looks good modulo Boris' comment; I'm fine with leaving
extra modes for later so long as they can be introduced without
disrupting existing users so the only question there would be if we
should name the init function in some way that's specific to the I/O
mode being used here.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]