From: Greg KH <gregkh@linuxfoundation.org>
To: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Cc: matthias.bgg@gmail.com, devel@driverdev.osuosl.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: mt7621-mmc: Use DIV_ROUND_UP in function msdc_set_mclk
Date: Tue, 16 Apr 2019 13:44:27 +0200 [thread overview]
Message-ID: <20190416114427.GA17623@kroah.com> (raw)
In-Reply-To: <20190403151608.27326-1-madhumithabiw@gmail.com>
On Wed, Apr 03, 2019 at 10:16:08AM -0500, Madhumitha Prabakaran wrote:
> Use DIV_ROUND_UP to make code simple and more understandable.
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> drivers/staging/mt7621-mmc/sd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
> index 4b26ec896a96..b12ed2c988fd 100644
> --- a/drivers/staging/mt7621-mmc/sd.c
> +++ b/drivers/staging/mt7621-mmc/sd.c
> @@ -240,7 +240,7 @@ static void msdc_set_mclk(struct msdc_host *host, int ddr, unsigned int hz)
> div = 1; /* mean div = 1/4 */
> sclk = hclk >> 2; /* sclk = clk / 4 */
> } else {
> - div = (hclk + ((hz << 2) - 1)) / (hz << 2);
> + div = DIV_ROUND_UP(hclk, (hz << 2));
> sclk = (hclk >> 2) / div;
> }
> } else if (hz >= hclk) { /* bug fix */
> @@ -253,7 +253,7 @@ static void msdc_set_mclk(struct msdc_host *host, int ddr, unsigned int hz)
> div = 0; /* mean div = 1/2 */
> sclk = hclk >> 1; /* sclk = clk / 2 */
> } else {
> - div = (hclk + ((hz << 2) - 1)) / (hz << 2);
> + div = DIV_ROUND_UP(hclk, (hz << 2));
> sclk = (hclk >> 2) / div;
> }
> }
This file is no longer in the kernel tree :(
prev parent reply other threads:[~2019-04-16 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 15:16 [PATCH] Staging: mt7621-mmc: Use DIV_ROUND_UP in function msdc_set_mclk Madhumitha Prabakaran
2019-04-16 11:44 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416114427.GA17623@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=madhumithabiw@gmail.com \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox