From: Mark Brown <broonie@kernel.org>
To: Vitor Soares <vitor.soares@synopsys.com>
Cc: linux-iio@vger.kernel.org, linux-i3c@lists.infradead.org,
linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, lars@metafoo.de,
knaack.h@gmx.de, jic23@kernel.org, lorenzo.bianconi83@gmail.com,
bbrezillon@kernel.org, rafael@kernel.org,
gregkh@linuxfoundation.org, joao.pinto@synopsys.com
Subject: Re: [PATCH 1/3] remap: Add I3C bus support
Date: Tue, 16 Apr 2019 16:39:48 +0100 [thread overview]
Message-ID: <20190416153948.GF4834@sirena.org.uk> (raw)
In-Reply-To: <c38e3cb9e8524af58c995a9cf1f79ddba69b47b4.1555354268.git.vitor.soares@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On Mon, Apr 15, 2019 at 09:19:39PM +0200, Vitor Soares wrote:
> +++ b/drivers/base/regmap/regmap-i3c.c
> @@ -0,0 +1,62 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.
Please make the entire header C++ style so it looks more consistent.
Otherwise this looks good modulo Boris' comment; I'm fine with leaving
extra modes for later so long as they can be introduced without
disrupting existing users so the only question there would be if we
should name the init function in some way that's specific to the I/O
mode being used here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-04-16 15:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 19:19 [PATCH 0/3] Add ST lsm6dso i3c suppport Vitor Soares
2019-04-15 19:19 ` [PATCH 1/3] remap: Add I3C bus support Vitor Soares
2019-04-16 6:15 ` Boris Brezillon
2019-04-16 14:41 ` Vitor Soares
2019-04-16 15:39 ` Mark Brown [this message]
2019-04-23 14:58 ` Vitor Soares
2019-04-23 15:14 ` Boris Brezillon
2019-04-23 15:55 ` Vitor Soares
2019-04-15 19:19 ` [PATCH 2/3] i3c: Add i3c_get_device_id helper Vitor Soares
2019-04-16 6:18 ` Boris Brezillon
2019-04-16 14:48 ` Vitor Soares
2019-04-15 19:19 ` [PATCH 3/3] iio: imu: st_lsm6dsx: Add i3c basic support Vitor Soares
2019-04-16 6:25 ` Boris Brezillon
2019-04-16 7:58 ` Lorenzo Bianconi
2019-04-16 8:05 ` Boris Brezillon
2019-04-16 15:00 ` Vitor Soares
2019-04-16 15:02 ` Vitor Soares
2019-04-16 6:32 ` [PATCH 0/3] Add ST lsm6dso i3c suppport Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416153948.GF4834@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bbrezillon@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=joao.pinto@synopsys.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=rafael@kernel.org \
--cc=vitor.soares@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox