From: Borislav Petkov <bp@alien8.de>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-edac@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/2] ras: close the race condition with timer
Date: Tue, 16 Apr 2019 19:42:59 +0200 [thread overview]
Message-ID: <20190416174259.GK31772@zn.tnic> (raw)
In-Reply-To: <CAM_iQpU6+xD+LmVtd=GPVp2zXgmLjT8tstRa7ia0pNgO0AcaPA@mail.gmail.com>
On Tue, Apr 16, 2019 at 10:09:49AM -0700, Cong Wang wrote:
> They are just locks requiring different contexts, I don't see how one is
> simpler than the other. Do you mind to be more specific?
Yes, I'd like for this whole CEC code to be lazy and preemptible as it
is not at all important when it does its work, as long as it gets it
done eventually.
Can't be preemptible with spinlocks.
> By workqueue, you must mean to say delayed work, right?
>
> But the global workqueue is not serialized either,
Serialized with what? Insertions?
That's what the mutex is for and the insertions happen in process
context.
So yeah, delayed_work sounds like what it should do. I.e.,
queue_delayed_work() and decay_interval_set() should do
mod_delayed_work(). Something along those lines, anyways.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-04-16 17:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 1:20 [PATCH 1/2] ras: fix an off-by-one error in __find_elem() Cong Wang
2019-04-16 1:20 ` [PATCH 2/2] ras: close the race condition with timer Cong Wang
2019-04-16 9:58 ` Borislav Petkov
2019-04-16 17:09 ` Cong Wang
2019-04-16 17:42 ` Borislav Petkov [this message]
2019-04-16 18:00 ` Cong Wang
2019-04-16 18:06 ` Cong Wang
2019-04-16 9:07 ` [PATCH 1/2] ras: fix an off-by-one error in __find_elem() Borislav Petkov
2019-04-16 17:01 ` Cong Wang
2019-04-16 22:18 ` Luck, Tony
2019-04-16 23:18 ` Cong Wang
2019-04-16 23:28 ` Luck, Tony
2019-04-16 23:47 ` Cong Wang
2019-04-17 1:53 ` Luck, Tony
2019-04-17 2:31 ` Cong Wang
2019-04-17 2:37 ` Cong Wang
2019-04-17 21:15 ` Luck, Tony
2019-04-18 22:54 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416174259.GK31772@zn.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox