Re: [PATCH V2 1/3] Calculate Thermal Pressure

Quentin Perret
2019-04-25T10:57:07Z

On Tuesday 16 Apr 2019 at 15:38:39 (-0400), Thara Gopinath wrote:
> +/* Per cpu structure to keep track of Thermal Pressure */
> +struct thermal_pressure {
> + unsigned long scale; /* scale reflecting average cpu max capacity*/
> + unsigned long acc_scale; /* Accumulated scale for this time window */
> + unsigned long old_scale; /* Scale value for the previous window */
> + unsigned long raw_scale; /* Raw max capacity */
> + unsigned long age_stamp; /* Last time old_scale was updated */
> + unsigned long last_update; /* Last time acc_scale was updated */
> + spinlock_t lock; /* Lock for protecting from simultaneous access*/
> + /* Timer for periodic update of thermal pressure */
> + struct timer_list timer;

Do you actually need the periodic update ? You only really need to
update the 'scale' value when updating the LB stats no ? Nobody
accesses that value in between two LBs.

Thanks,
Quentin