From: Ingo Molnar <mingo@kernel.org>
To: tglx@linutronix.de, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, hpa@zytor.com,
peterz@infradead.org, yuehaibing@huawei.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched/core: Make some functions static
Date: Thu, 18 Apr 2019 14:48:36 +0200 [thread overview]
Message-ID: <20190418124836.GB104512@gmail.com> (raw)
In-Reply-To: <tip-16e671afb70f28eb189136d1395c59dafecd270a@git.kernel.org>
* tip-bot for YueHaibing <tipbot@zytor.com> wrote:
> Commit-ID: 16e671afb70f28eb189136d1395c59dafecd270a
> Gitweb: https://git.kernel.org/tip/16e671afb70f28eb189136d1395c59dafecd270a
> Author: YueHaibing <yuehaibing@huawei.com>
> AuthorDate: Fri, 22 Mar 2019 22:31:53 +0800
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Thu, 18 Apr 2019 14:19:25 +0200
>
> sched/core: Make some functions static
>
> Fix these sparse warnings:
>
> kernel/sched/core.c:6576:11: warning: symbol 'max_cfs_quota_period' was not declared. Should it be static?
> kernel/sched/core.c:6577:11: warning: symbol 'min_cfs_quota_period' was not declared. Should it be static?
> kernel/sched/core.c:6657:5: warning: symbol 'tg_set_cfs_quota' was not declared. Should it be static?
> kernel/sched/core.c:6670:6: warning: symbol 'tg_get_cfs_quota' was not declared. Should it be static?
> kernel/sched/core.c:6683:5: warning: symbol 'tg_set_cfs_period' was not declared. Should it be static?
> kernel/sched/core.c:6693:6: warning: symbol 'tg_get_cfs_period' was not declared. Should it be static?
> kernel/sched/fair.c:2596:6: warning: symbol 'task_tick_numa' was not declared. Should it be static?
So unless this is somehow version dependent or other changes interfered,
this patch wasn't tested very well:
kernel/sched/fair.o: In function `sched_cfs_period_timer':
fair.c:(.text+0x920c): undefined reference to `max_cfs_quota_period'
fair.c:(.text+0x9214): undefined reference to `max_cfs_quota_period'
skipping it for now.
Thanks,
Ingo
next prev parent reply other threads:[~2019-04-18 12:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 14:31 [PATCH -next] sched/core: Make some functions static Yue Haibing
2019-04-18 12:25 ` [tip:sched/core] " tip-bot for YueHaibing
2019-04-18 12:48 ` Ingo Molnar [this message]
2019-04-18 13:17 ` YueHaibing
2019-04-18 13:29 ` [PATCH v2 -next] " Yue Haibing
2019-04-18 13:40 ` Ingo Molnar
2019-04-18 14:26 ` YueHaibing
2019-04-18 14:47 ` [PATCH v3 " Yue Haibing
2019-04-18 18:31 ` [tip:sched/core] " tip-bot for YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418124836.GB104512@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox