Re: [PATCH] compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING

LEROY Christophe
2019-03-23T08:26:45Z

Arnd Bergmann <arnd@arndb.de> a écrit :

> On Wed, Mar 20, 2019 at 10:41 AM Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> I've added your patch to my randconfig test setup and will let you
>> know if I see anything noticeable. I'm currently testing clang-arm32,
>> clang-arm64 and gcc-x86.
>
> This is the only additional bug that has come up so far:
>
> `.exit.text' referenced in section `.alt.smp.init' of
> drivers/char/ipmi/ipmi_msghandler.o: defined in discarded section
> `exit.text' of drivers/char/ipmi/ipmi_msghandler.o

Wouldn't it be useful to activate -Winline gcc warning to ease finding
out problematic usage of inline keyword ?

Christophe

>
> diff --git a/arch/arm/kernel/atags.h b/arch/arm/kernel/atags.h
> index 201100226301..84b12e33104d 100644
> --- a/arch/arm/kernel/atags.h
> +++ b/arch/arm/kernel/atags.h
> @@ -5,7 +5,7 @@ void convert_to_tag_list(struct tag *tags);
> const struct machine_desc *setup_machine_tags(phys_addr_t __atags_pointer,
> unsigned int machine_nr);
> #else
> -static inline const struct machine_desc *
> +static __always_inline const struct machine_desc *
> setup_machine_tags(phys_addr_t __atags_pointer, unsigned int machine_nr)
> {
> early_print("no ATAGS support: can't continue\n");