From: Keith Busch <kbusch@kernel.org>
To: Aaron Ma <aaron.ma@canonical.com>
Cc: Maxim Levitsky <mlevitsk@redhat.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
keith.busch@intel.com, axboe@fb.com
Subject: Re: [PATCH] nvme: determine the number of IO queues
Date: Thu, 18 Apr 2019 07:48:21 -0600 [thread overview]
Message-ID: <20190418134820.GA7589@localhost.localdomain> (raw)
In-Reply-To: <e79703d5-3502-6519-a497-71b2b2a8768f@canonical.com>
On Thu, Apr 18, 2019 at 02:21:57PM +0800, Aaron Ma wrote:
> On 4/18/19 1:33 AM, Maxim Levitsky wrote:
> >>
> >> Maybe its better to add a quirk for the broken device, which needs this?
>
> Adding quirk only makes the code more complicated.
> This patch doesn't change the default behavior.
> Only handle the NVME error code.
It does change the default behavior. If I have a degraded controller that
can't do IO in a machine with 1000's of CPUs, I have to iterate this
non-standard behavior 1000's of times before the drive is servicable
again. We currenlty figure that out in just a single try.
At least the quirks document *why* the driver is doing non-standard
behavior. We do the IO queue quirks for Macbooks, for example.
But why don't you file a bug report with the device vendor instead? Surely
a firmware fix provides the best possible outcome, and would make this
device work not only in all versions of Linux, but also every standard
compliant driver for any OS.
next prev parent reply other threads:[~2019-04-18 13:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 14:12 [PATCH] nvme: determine the number of IO queues Aaron Ma
2019-04-17 17:32 ` Maxim Levitsky
2019-04-17 17:33 ` Maxim Levitsky
2019-04-18 6:21 ` Aaron Ma
2019-04-18 7:25 ` Maxim Levitsky
2019-04-18 12:13 ` Minwoo Im
2019-04-18 12:52 ` Aaron Ma
2019-04-18 13:33 ` Minwoo Im
2019-04-18 13:38 ` Aaron Ma
2019-04-18 13:58 ` Minwoo Im
2019-04-18 13:48 ` Keith Busch [this message]
2019-04-18 14:21 ` Aaron Ma
2019-04-25 14:39 ` Christoph Hellwig
2019-04-26 5:27 ` Aaron Ma
2019-04-17 21:30 ` Edmund Nadolski (Microsoft)
2019-04-18 6:24 ` Aaron Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418134820.GA7589@localhost.localdomain \
--to=kbusch@kernel.org \
--cc=aaron.ma@canonical.com \
--cc=axboe@fb.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlevitsk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox