From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, URIBL_RHS_DOB,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6221C10F0E for ; Thu, 18 Apr 2019 14:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEF682083D for ; Thu, 18 Apr 2019 14:04:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389090AbfDROE2 (ORCPT ); Thu, 18 Apr 2019 10:04:28 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:60859 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388392AbfDROE2 (ORCPT ); Thu, 18 Apr 2019 10:04:28 -0400 X-Originating-IP: 90.88.160.238 Received: from localhost (aaubervilliers-681-1-42-238.w90-88.abo.wanadoo.fr [90.88.160.238]) (Authenticated sender: maxime.ripard@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 5F51EE000D; Thu, 18 Apr 2019 14:04:24 +0000 (UTC) Date: Thu, 18 Apr 2019 16:04:23 +0200 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Michael Trimarchi , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com Subject: Re: [PATCH v3 1/2] arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node Message-ID: <20190418140423.ch43fz2xuk5teqyl@flea> References: <20190418134838.8806-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yq5wyvarasweczql" Content-Disposition: inline In-Reply-To: <20190418134838.8806-1-jagan@amarulasolutions.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yq5wyvarasweczql Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 18, 2019 at 07:18:37PM +0530, Jagan Teki wrote: > Add Goodix GT5663 capacitive touch controller node on > Amarula A64-Relic board. > > The CTP connected to board with, > - SDA, SCK from i2c1 > - GPIO-LD0 as AVDD28 supply > - PH4 gpio as interrupt pin > - PH8 gpio as reset pin > - X axis is inverted > - Y axis is inverted > > Signed-off-by: Jagan Teki > --- > Changes for v3: > - Use 2.8v for reg_ldo_io0 > Changes for v2: > - drop i2c1, bias-pull-up > > .../allwinner/sun50i-a64-amarula-relic.dts | 25 +++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > index 3575db216016..bd31a4385bc1 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts > @@ -49,6 +49,24 @@ > bias-pull-up; > }; > > +&i2c1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; You haven't fixed this, and you didn't either in the second patch. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --yq5wyvarasweczql Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLiD5wAKCRDj7w1vZxhR xapuAQD8LXXiwV2C8+Q/hMbkagCFBW2SZrR1MchpN/9JMZUv/QEAl60kizNVwuTV NoGTBp8RoYzD8dJzb2gYqQR6gxFVhwY= =o9S1 -----END PGP SIGNATURE----- --yq5wyvarasweczql--