From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F2BEC282DD for ; Fri, 19 Apr 2019 00:45:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 636BA217F9 for ; Fri, 19 Apr 2019 00:45:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="Vh4McX3m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726626AbfDSApX (ORCPT ); Thu, 18 Apr 2019 20:45:23 -0400 Received: from mail.skyhub.de ([5.9.137.197]:44226 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbfDSApX (ORCPT ); Thu, 18 Apr 2019 20:45:23 -0400 Received: from zn.tnic (p200300EC2F112E00C9E732E76EE3BD2F.dip0.t-ipconnect.de [IPv6:2003:ec:2f11:2e00:c9e7:32e7:6ee3:bd2f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C4A961EC0104; Fri, 19 Apr 2019 02:45:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1555634721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=B7TKCB1OFmsr7NkJTn8+NmAwe312DePuJSu/N+DUWxo=; b=Vh4McX3m4glVjnUI3lCOaV2pdc+PabbFN6qWUdyYyAxBtE51Cf50G8+3Srylagz2JScmif yQE0q6EOynnSTNQsO7wJ9Pl9+EzoEGk7TwtBiP59sMJvFvLs7Jpx/wyQKjkWW+qtoeF8kg mMD9R/JgoTgwJg8RVKOXbnCnOW7lG2A= Date: Fri, 19 Apr 2019 02:45:16 +0200 From: Borislav Petkov To: PanBian , Greg KH Cc: Mauro Carvalho Chehab , James Morse , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: EDAC: Fix memory leak in creating CSROW object Message-ID: <20190419004516.GC559@zn.tnic> References: <1555554438-103953-1-git-send-email-bianpan2016@163.com> <20190418172548.GL27160@zn.tnic> <20190419003536.GA57795@bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190419003536.GA57795@bianpan2016@163.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 19, 2019 at 08:35:36AM +0800, PanBian wrote: > Yes, I see that. Because the loop start with (--i), there is no put > operation for the device that fails to create. So, I think we cannot > rule out the possibility of memory leak. Ok, so this is not something you trigger - you're basically staring at the code? Well, there's something else questionable in that code which I asked Greg about today but we didn't finish that conversation, let me CC him. So AFAIU, devices for which device_add() has returned success, should be removed with their counterpart device_del(). edac_create_csrow_objects(), however, does put_device() on those in the "unwinding" loop. And for the case where device_add() fails, you should do put_device() to it. I.e., what you're saying. So I think we need to figure what needs to be done when before fixing this properly. Greg? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.