From: Borislav Petkov <bp@alien8.de>
To: WANG Chao <chao.wang@ucloud.cn>
Cc: Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH 3/3] RAS/CEC: immediate soft-offline page when count_threshold == 1
Date: Sat, 20 Apr 2019 13:57:19 +0200 [thread overview]
Message-ID: <20190420115719.GD29704@zn.tnic> (raw)
In-Reply-To: <20190418034115.75954-3-chao.wang@ucloud.cn>
On Thu, Apr 18, 2019 at 11:41:15AM +0800, WANG Chao wrote:
> count_threshol == 1 isn't working as expected. CEC only does soft
> offline the second time the same pfn is hit by a correctable error.
So this?
---
diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index b3c377ddf340..750a427e1a73 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -333,6 +333,7 @@ int cec_add_elem(u64 pfn)
mutex_lock(&ce_mutex);
+ /* Array full, free the LRU slot. */
if (ca->n == MAX_ELEMS)
WARN_ON(!del_lru_elem_unlocked(ca));
@@ -346,14 +347,9 @@ int cec_add_elem(u64 pfn)
(void *)&ca->array[to],
(ca->n - to) * sizeof(u64));
- ca->array[to] = (pfn << PAGE_SHIFT) |
- (DECAY_MASK << COUNT_BITS) | 1;
+ ca->array[to] = (pfn << PAGE_SHIFT) | 1;
ca->n++;
-
- ret = 0;
-
- goto decay;
}
count = COUNT(ca->array[to]);
@@ -386,7 +382,6 @@ int cec_add_elem(u64 pfn)
goto unlock;
}
-decay:
ca->decay_count++;
if (ca->decay_count >= CLEAN_ELEMS)
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-04-20 11:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 3:41 [PATCH 1/3] RAS/CEC: fix __find_elem WANG Chao
2019-04-18 3:41 ` [PATCH 2/3] RAS/CEC: make ces_entered smp safe WANG Chao
2019-04-20 10:19 ` [tip:ras/core] RAS/CEC: Increment cec_entered under the mutex lock tip-bot for WANG Chao
2019-04-20 10:22 ` tip-bot for WANG Chao
2019-04-18 3:41 ` [PATCH 3/3] RAS/CEC: immediate soft-offline page when count_threshold == 1 WANG Chao
2019-04-20 11:57 ` Borislav Petkov [this message]
2019-04-24 2:43 ` WANG Chao
2019-04-24 10:26 ` Borislav Petkov
2019-06-08 21:26 ` [tip:ras/core] RAS/CEC: Check count_threshold unconditionally tip-bot for Borislav Petkov
2019-04-25 7:56 ` [PATCH 1/3] RAS/CEC: fix __find_elem WANG Chao
2019-04-25 8:05 ` WANG Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190420115719.GD29704@zn.tnic \
--to=bp@alien8.de \
--cc=chao.wang@ucloud.cn \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox