From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1304CC282E1 for ; Mon, 22 Apr 2019 07:20:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA7BA2075A for ; Mon, 22 Apr 2019 07:20:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726793AbfDVHUe (ORCPT ); Mon, 22 Apr 2019 03:20:34 -0400 Received: from sauhun.de ([88.99.104.3]:40918 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725914AbfDVHUe (ORCPT ); Mon, 22 Apr 2019 03:20:34 -0400 Received: from localhost (p54B33299.dip0.t-ipconnect.de [84.179.50.153]) by pokefinder.org (Postfix) with ESMTPSA id CF4892C2868; Mon, 22 Apr 2019 09:20:31 +0200 (CEST) Date: Mon, 22 Apr 2019 09:20:31 +0200 From: Wolfram Sang To: Peter Rosin Cc: "Gustavo A. R. Silva" , Wolfram Sang , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] i2c: mux: demux-pinctrl: use struct_size() in devm_kzalloc() Message-ID: <20190422072031.GA1005@kunai> References: <20190104174327.GA30932@embeddedor> <20190104180612.GE3009@kunai> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oyUTqETQ0mS9luUI" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --oyUTqETQ0mS9luUI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 21, 2019 at 06:15:21PM +0000, Peter Rosin wrote: > On 2019-01-04 19:06, Wolfram Sang wrote: > >=20 > >> Instead of leaving these open-coded and prone to type mistakes, we can > >> now use the new struct_size() helper: > >=20 > > I am okay with this patch in general. However, I think the name of the > > helper 'struct_size' is a bit unfortunate. I really wondered on the > > first read why it needs 3 arguments to find out a struct size. I only > > understood on the second read. I think 'trailing_array_struct_size' > > would be way more clearer what it does. >=20 > I read that as an Acked-by... :-) For this patch, yes. Thanks! --oyUTqETQ0mS9luUI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAly9azsACgkQFA3kzBSg KbZIrxAAqRI/lLE1BL3c3a5BTNhbBG4FbJuZWSOsVq+RMKxeHoBBes+os1ttWfRf Crrf9IgmnmsW6yvJAvDmBm14mBx2ZUw98o5LYAnZqmuA0uMqtMDEHBDkDqYnN+cw 78o8WiTbjmC481JdoQCgmsrs1KhyqxCiEV8NnsQlDshCKSbU9xWJM+lR/O6oRt3G kAI58FqIlSMf76Lhwx7PVio0Gxf2xXVCGkugAOCQwC6+7PgquoUGRh/hryh8bdIb P2wq4XDu0B377vpAKxysAzDXtVuB0T1qn8xk2ndYv2jh2Rj+sNd7aeAgybBt1z42 qkpKuIDUqiueZkSBAeqns2ybKh5rCAPfzrnHVcsCIM88SxtzdU5kpiMyO2/+Kvm9 B2onHNBwANh1Grzk3UHYIkZAI6zqb3tBK8aOtAHeQnB2mI1GYjfKxAHbhyrRIe75 RSfWfAldOxof6iPU+ezMD1zmQHwZEZDGp9FYVx+P9CbuuDehiiGzVl4txYCntOaJ 9RqwXpLZHwfFc/lftPZeEfp1X09rzxhWWmsdPNgdc4JmmnZL/wEm//kuXHkXnPmw 7mp2TfvPjag8ZfPka0wjRREGLX3iL2u2D3FN72GuxyvpTR9MMeWoVP1smNDo17yL WFu0eFx10Fun8+M2sS7VdYuw9SeNK5LYsn3sVfucUg0sVpjfTwk= =SM1N -----END PGP SIGNATURE----- --oyUTqETQ0mS9luUI--