Re: [PATCH] x86_64: uninline TASK_SIZE

Ingo Molnar
2019-04-24T10:38:40Z

* Andy Lutomirski <luto@kernel.org> wrote:

> > Or am I missing some complication?
>
> Seems like a great idea to me.
>
> BTW, what the heck is up with get_gate_page()? I'm struggling to
> understand what it's even trying to do. If there's an architecture
> that allows a user program to mremap() or otherwise position its gate
> VMA between TASK_SIZE and TASK_SIZE_MAX, then that code is going to
> explode horribly.

I believe it was an old attempt from the times when the vsyscall area
*didn't* have a vma, at all, and only get_gate_page() kept the mmap
allocator from overlapping it with a user vma?

Should IMHO be entirely solved by the vma-ification of all things
vsyscall and vdso, and we can remove this remnant.

> A whole bunch of work in this direction is here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h=x86/fixes
>
> It's almost entirely untested.

Please post it as patches once you are somewhat confident in the outcome
and general direction.

Thanks,

Ingo