From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mohan Kumar <mohankumar718@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-iio@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] drivers/iio/gyro/mpu3050-core.c: This patch fix the following checkpatch warning.
Date: Mon, 22 Apr 2019 10:45:23 +0100 [thread overview]
Message-ID: <20190422104523.4bfca4ad@archlinux> (raw)
In-Reply-To: <CACRpkdY5cX=aP9nNwWeUd0Nx33MS0QJDnLKzbajADRsKCUVbOA@mail.gmail.com>
On Tue, 16 Apr 2019 13:50:18 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Sun, Apr 14, 2019 at 5:53 PM Mohan Kumar <mohankumar718@gmail.com> wrote:
>
> > As per Documentation/timers/timers-howto.txt Msleep < 20ms can sleep for
> > up to 20ms. so use usleep_range.
> >
> > Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
>
> All right, should work as fine.
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks and applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Whilst we are here, there is a 'false' warning that we should clear up at
somepoint (from sparse)
CHECK drivers/iio/gyro/mpu3050-core.c
drivers/iio/gyro/mpu3050-core.c:544:48: warning: incorrect type in assignment (different base types)
drivers/iio/gyro/mpu3050-core.c:544:48: expected restricted __be16 <noident>
drivers/iio/gyro/mpu3050-core.c:544:48: got int
Line in question is setting the __be16 value to 0xAAAA where endian choice has
no effect. I'll send out the trivial 'fix' in a minute. Give the compiler
can sort it out at build time it should make no actual difference.
Usual arguments apply for why we bother to suppress 'false' build warnings
like this...
Anyhow patch shortly.
Jonathan
>
> Yours,
> Linus Walleij
prev parent reply other threads:[~2019-04-22 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 15:53 [RESEND PATCH] drivers/iio/gyro/mpu3050-core.c: This patch fix the following checkpatch warning Mohan Kumar
2019-04-16 11:50 ` Linus Walleij
2019-04-22 9:45 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422104523.4bfca4ad@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohankumar718@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox