From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ECD5C10F11 for ; Mon, 22 Apr 2019 19:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8C7A20643 for ; Mon, 22 Apr 2019 19:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555963071; bh=rdhfLSfSb+9wabCku/XMEhRo3Kp9c9dLD+jQwWZjK7c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=14dOEpYeUbfs1qFF5nYoYf5IKUk0FGVS3MqizGl43SYFqOr3cbUKZBaYf+6/2l+8T VnhC+DcmW+BZ3t9yE1OM9Dmuwo4g0pU4+xHl9iITf/6J5RWIPbi/+WaofhIyU6ylxN sLrK3JcyrFArhZE3smjC2QjgxsigcssuOd4kcJIk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731735AbfDVT5t (ORCPT ); Mon, 22 Apr 2019 15:57:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:51970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730573AbfDVTsf (ORCPT ); Mon, 22 Apr 2019 15:48:35 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 51FC421905; Mon, 22 Apr 2019 19:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555962515; bh=rdhfLSfSb+9wabCku/XMEhRo3Kp9c9dLD+jQwWZjK7c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GzmHjMilN3lGxkmjnkzpyXmrMJpuWBRLNLZp+PJbnwgUOukn71dl+TL1GAFhGx76y 7EpqtztdNfvXoagLn1pNlyBe1fk2ydHGpcMevESDtZrBbTHjOFjEooZbzq+n8P8a8Y k6IPZ4UVcwTZN2rxe/nHxqemiWW2c2n4sKe32aaY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mukesh Ojha , Greg Kroah-Hartman , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 34/43] usb: u132-hcd: fix resource leak Date: Mon, 22 Apr 2019 15:47:18 -0400 Message-Id: <20190422194727.12495-34-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190422194727.12495-1-sashal@kernel.org> References: <20190422194727.12495-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mukesh Ojha [ Upstream commit f276e002793cdb820862e8ea8f76769d56bba575 ] if platform_driver_register fails, cleanup the allocated resource gracefully. Signed-off-by: Mukesh Ojha Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin (Microsoft) --- drivers/usb/host/u132-hcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c index 65c0086e25ae..8d349230b2c7 100644 --- a/drivers/usb/host/u132-hcd.c +++ b/drivers/usb/host/u132-hcd.c @@ -3208,6 +3208,9 @@ static int __init u132_hcd_init(void) printk(KERN_INFO "driver %s\n", hcd_name); workqueue = create_singlethread_workqueue("u132"); retval = platform_driver_register(&u132_platform_driver); + if (retval) + destroy_workqueue(workqueue); + return retval; } -- 2.19.1