From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Jiang Biao <benbjiang@tencent.com>
Cc: josh@joshtriplett.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu/tree_exp: cleanup initialized but not used rdp
Date: Tue, 23 Apr 2019 01:06:44 -0700 [thread overview]
Message-ID: <20190423080644.GC3923@linux.ibm.com> (raw)
In-Reply-To: <20190423012155.30606-1-benbjiang@tencent.com>
On Tue, Apr 23, 2019 at 09:21:55AM +0800, Jiang Biao wrote:
> rdp is initialized but never used in synchronize_rcu_expedited(),
> just remove it.
>
> Signed-off-by: Jiang Biao <benbjiang@tencent.com>
I queued and pushed both patches for testing and review, good eyes,
thank you! I reworded the subject and commit logs, so could you please
check to make sure that I didn't mess anything up?
Thanx, Paul
> ---
> kernel/rcu/tree_exp.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
> index 4c2a0189e748..5772612379e4 100644
> --- a/kernel/rcu/tree_exp.h
> +++ b/kernel/rcu/tree_exp.h
> @@ -733,7 +733,6 @@ static void sync_sched_exp_online_cleanup(int cpu)
> */
> void synchronize_rcu_expedited(void)
> {
> - struct rcu_data *rdp;
> struct rcu_exp_work rew;
> struct rcu_node *rnp;
> unsigned long s;
> @@ -770,7 +769,6 @@ void synchronize_rcu_expedited(void)
> }
>
> /* Wait for expedited grace period to complete. */
> - rdp = per_cpu_ptr(&rcu_data, raw_smp_processor_id());
> rnp = rcu_get_root();
> wait_event(rnp->exp_wq[rcu_seq_ctr(s) & 0x3],
> sync_exp_work_done(s));
> --
> 2.17.2 (Apple Git-113)
>
next prev parent reply other threads:[~2019-04-23 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 1:21 [PATCH] rcu/tree_exp: cleanup initialized but not used rdp Jiang Biao
2019-04-23 8:06 ` Paul E. McKenney [this message]
2019-04-23 8:45 ` [PATCH] rcu/tree_exp: cleanup initialized but not used rdp(Internet mail) benbjiang(蒋彪)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423080644.GC3923@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=benbjiang@tencent.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox