* [PATCH] rcu/tree_exp: cleanup initialized but not used rdp
@ 2019-04-23 1:21 Jiang Biao
2019-04-23 8:06 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: Jiang Biao @ 2019-04-23 1:21 UTC (permalink / raw)
To: paulmck, josh; +Cc: linux-kernel, benbjiang
rdp is initialized but never used in synchronize_rcu_expedited(),
just remove it.
Signed-off-by: Jiang Biao <benbjiang@tencent.com>
---
kernel/rcu/tree_exp.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
index 4c2a0189e748..5772612379e4 100644
--- a/kernel/rcu/tree_exp.h
+++ b/kernel/rcu/tree_exp.h
@@ -733,7 +733,6 @@ static void sync_sched_exp_online_cleanup(int cpu)
*/
void synchronize_rcu_expedited(void)
{
- struct rcu_data *rdp;
struct rcu_exp_work rew;
struct rcu_node *rnp;
unsigned long s;
@@ -770,7 +769,6 @@ void synchronize_rcu_expedited(void)
}
/* Wait for expedited grace period to complete. */
- rdp = per_cpu_ptr(&rcu_data, raw_smp_processor_id());
rnp = rcu_get_root();
wait_event(rnp->exp_wq[rcu_seq_ctr(s) & 0x3],
sync_exp_work_done(s));
--
2.17.2 (Apple Git-113)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rcu/tree_exp: cleanup initialized but not used rdp
2019-04-23 1:21 [PATCH] rcu/tree_exp: cleanup initialized but not used rdp Jiang Biao
@ 2019-04-23 8:06 ` Paul E. McKenney
2019-04-23 8:45 ` [PATCH] rcu/tree_exp: cleanup initialized but not used rdp(Internet mail) benbjiang(蒋彪)
0 siblings, 1 reply; 3+ messages in thread
From: Paul E. McKenney @ 2019-04-23 8:06 UTC (permalink / raw)
To: Jiang Biao; +Cc: josh, linux-kernel
On Tue, Apr 23, 2019 at 09:21:55AM +0800, Jiang Biao wrote:
> rdp is initialized but never used in synchronize_rcu_expedited(),
> just remove it.
>
> Signed-off-by: Jiang Biao <benbjiang@tencent.com>
I queued and pushed both patches for testing and review, good eyes,
thank you! I reworded the subject and commit logs, so could you please
check to make sure that I didn't mess anything up?
Thanx, Paul
> ---
> kernel/rcu/tree_exp.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
> index 4c2a0189e748..5772612379e4 100644
> --- a/kernel/rcu/tree_exp.h
> +++ b/kernel/rcu/tree_exp.h
> @@ -733,7 +733,6 @@ static void sync_sched_exp_online_cleanup(int cpu)
> */
> void synchronize_rcu_expedited(void)
> {
> - struct rcu_data *rdp;
> struct rcu_exp_work rew;
> struct rcu_node *rnp;
> unsigned long s;
> @@ -770,7 +769,6 @@ void synchronize_rcu_expedited(void)
> }
>
> /* Wait for expedited grace period to complete. */
> - rdp = per_cpu_ptr(&rcu_data, raw_smp_processor_id());
> rnp = rcu_get_root();
> wait_event(rnp->exp_wq[rcu_seq_ctr(s) & 0x3],
> sync_exp_work_done(s));
> --
> 2.17.2 (Apple Git-113)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rcu/tree_exp: cleanup initialized but not used rdp(Internet mail)
2019-04-23 8:06 ` Paul E. McKenney
@ 2019-04-23 8:45 ` benbjiang(蒋彪)
0 siblings, 0 replies; 3+ messages in thread
From: benbjiang(蒋彪) @ 2019-04-23 8:45 UTC (permalink / raw)
To: paulmck@linux.ibm.com; +Cc: josh@joshtriplett.org, linux-kernel@vger.kernel.org
> 在 2019年4月23日，下午4:06，Paul E. McKenney <paulmck@linux.ibm.com> 写道：
>
> On Tue, Apr 23, 2019 at 09:21:55AM +0800, Jiang Biao wrote:
>> rdp is initialized but never used in synchronize_rcu_expedited(),
>> just remove it.
>>
>> Signed-off-by: Jiang Biao <benbjiang@tencent.com>
>
> I queued and pushed both patches for testing and review, good eyes,
> thank you! I reworded the subject and commit logs, so could you please
> check to make sure that I didn't mess anything up?
>
> Thanx, Paul
>
Already checked, everything’s good to me. Thanks a lot.
Jiang,
>> ---
>> kernel/rcu/tree_exp.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
>> index 4c2a0189e748..5772612379e4 100644
>> --- a/kernel/rcu/tree_exp.h
>> +++ b/kernel/rcu/tree_exp.h
>> @@ -733,7 +733,6 @@ static void sync_sched_exp_online_cleanup(int cpu)
>> */
>> void synchronize_rcu_expedited(void)
>> {
>> - struct rcu_data *rdp;
>> struct rcu_exp_work rew;
>> struct rcu_node *rnp;
>> unsigned long s;
>> @@ -770,7 +769,6 @@ void synchronize_rcu_expedited(void)
>> }
>>
>> /* Wait for expedited grace period to complete. */
>> - rdp = per_cpu_ptr(&rcu_data, raw_smp_processor_id());
>> rnp = rcu_get_root();
>> wait_event(rnp->exp_wq[rcu_seq_ctr(s) & 0x3],
>> sync_exp_work_done(s));
>> --
>> 2.17.2 (Apple Git-113)
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-23 8:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-23 1:21 [PATCH] rcu/tree_exp: cleanup initialized but not used rdp Jiang Biao
2019-04-23 8:06 ` Paul E. McKenney
2019-04-23 8:45 ` [PATCH] rcu/tree_exp: cleanup initialized but not used rdp(Internet mail) benbjiang(蒋彪)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox