From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 588B1C282E1 for ; Tue, 23 Apr 2019 13:35:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29DFB214AE for ; Tue, 23 Apr 2019 13:35:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727817AbfDWNf5 (ORCPT ); Tue, 23 Apr 2019 09:35:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46786 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726655AbfDWNf5 (ORCPT ); Tue, 23 Apr 2019 09:35:57 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B112E30054AB; Tue, 23 Apr 2019 13:35:56 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.38]) by smtp.corp.redhat.com (Postfix) with SMTP id 739D25D71E; Tue, 23 Apr 2019 13:35:54 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 23 Apr 2019 15:35:56 +0200 (CEST) Date: Tue, 23 Apr 2019 15:35:53 +0200 From: Oleg Nesterov To: weizhenliang Cc: "ebiederm@xmission.com" , "colona@arista.com" , "akpm@linux-foundation.org" , "christian@brauner.io" , "arnd@arndb.de" , "tglx@linutronix.de" , "deepa.kernel@gmail.com" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit Message-ID: <20190423133553.GA5921@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 23 Apr 2019 13:35:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/23, weizhenliang wrote: > > On Mon, Apr 22, 2019 at 11:25 PM Oleg Nesterov wrote: > >On 04/22, Zhenliang Wei wrote: > >> > >> --- a/kernel/signal.c > >> +++ b/kernel/signal.c > >> @@ -2441,6 +2441,7 @@ bool get_signal(struct ksignal *ksig) > >> if (signal_group_exit(signal)) { > >> ksig->info.si_signo = signr = SIGKILL; > >> sigdelset(¤t->pending.signal, SIGKILL); > >> + trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL); > >> recalc_sigpending(); > >> goto fatal; > >> } > > > >Reviewed-by: Oleg Nesterov > > Last time Oleg suggested using SIG_DFL as the third parameter, but its type is 'void (*)(int)', but not expected 'struct k_sigaction *'. Yes I misread the signature of TRACE_EVENT(signal_deliver), and I thought you at least compiled the kernel with your patch applied ;) > How about > trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, &sighand->action[signr - 1]); > ? sure, this should fix the problem. Oleg.