From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: Zhenliang Wei <weizhenliang@huawei.com>,
ebiederm@xmission.com, colona@arista.com,
akpm@linux-foundation.org, arnd@arndb.de, tglx@linutronix.de,
deepa.kernel@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v4] signal: trace_signal_deliver when signal_group_exit
Date: Wed, 24 Apr 2019 15:25:03 +0200 [thread overview]
Message-ID: <20190424132502.GE16167@redhat.com> (raw)
In-Reply-To: <20190424130751.jckvq535ipfx5cq6@brauner.io>
On 04/24, Christian Brauner wrote:
>
> On Wed, Apr 24, 2019 at 08:52:38PM +0800, Zhenliang Wei wrote:
>
> > Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Yes, but ...
> > Reported-by: kbuild test robot <lkp@intel.com>
Hmm, really?
> > --- a/kernel/signal.c
> > +++ b/kernel/signal.c
> > @@ -2441,6 +2441,8 @@ bool get_signal(struct ksignal *ksig)
> > if (signal_group_exit(signal)) {
> > ksig->info.si_signo = signr = SIGKILL;
> > sigdelset(¤t->pending.signal, SIGKILL);
> > + trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO,
> > + &sighand->action[signr - 1]);
>
> Hm, sorry for being the really nitpicky person here. Just for the sake
> of consistency how about we do either:
>
> + trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO,
> + &sighand->action[SIGKILL - 1]);
>
> or
>
> + trace_signal_deliver(signr, SEND_SIG_NOINFO,
> + &sighand->action[signr - 1]);
Agreed!
Oleg.
prev parent reply other threads:[~2019-04-24 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 12:52 [PATCH v4] signal: trace_signal_deliver when signal_group_exit Zhenliang Wei
2019-04-24 13:07 ` Christian Brauner
2019-04-24 13:25 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424132502.GE16167@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christian@brauner.io \
--cc=colona@arista.com \
--cc=deepa.kernel@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=weizhenliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox