From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87316C10F11 for ; Wed, 24 Apr 2019 14:42:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4AFDA218B0 for ; Wed, 24 Apr 2019 14:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556116975; bh=A8DnE8KRb0LOjpot/GtLTMRzgmaEW43z05ksHucui8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tUgvs1yzVG/vFU1ggYbyVuF0Ea6cXFIui1WNw8vPtu6cm4tOAhak/almokiuoOIg9 2P7Qa0y8zIo1AD1GW/ttV7Yq6eIHNlwqxiVJ4tc+GUwFmhjrW51IDkF1PnEuxyITq6 LhtBOfuqI4VKUQ14OvKxuYTIwn8/B4tl4LmklsyY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731943AbfDXOk2 (ORCPT ); Wed, 24 Apr 2019 10:40:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:42804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731913AbfDXOkR (ORCPT ); Wed, 24 Apr 2019 10:40:17 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B37F21907; Wed, 24 Apr 2019 14:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556116816; bh=A8DnE8KRb0LOjpot/GtLTMRzgmaEW43z05ksHucui8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mq/CI1/1cYbOP8OkherXjHvMrLe/pMHH/GT3KJW0QF1SEgctE24ZLG3MRm31IvZPV pzE/yV/R5azZn4gAoO1jBSW2NwTptCxhwLzgnvYSC4F2ZKjHdfM/R+BYyNiqNpr3WJ ZTVSAiv7o0+maB+kdm7+yF7bQ9c8LFf+R7JT0C3s= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Shenghui Wang , Jens Axboe , Sasha Levin , linux-block@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 28/52] block: use blk_free_flush_queue() to free hctx->fq in blk_mq_init_hctx Date: Wed, 24 Apr 2019 10:38:46 -0400 Message-Id: <20190424143911.28890-28-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190424143911.28890-1-sashal@kernel.org> References: <20190424143911.28890-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shenghui Wang [ Upstream commit b9a1ff504b9492ad6beb7d5606e0e3365d4d8499 ] kfree() can leak the hctx->fq->flush_rq field. Reviewed-by: Ming Lei Signed-off-by: Shenghui Wang Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 7d53f2314d7c..414656796ecf 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2236,7 +2236,7 @@ static int blk_mq_init_hctx(struct request_queue *q, return 0; free_fq: - kfree(hctx->fq); + blk_free_flush_queue(hctx->fq); exit_hctx: if (set->ops->exit_hctx) set->ops->exit_hctx(hctx, hctx_idx); -- 2.19.1