From: Christoph Hellwig <hch@infradead.org>
To: Tom Murphy <tmurphy@arista.com>, Joerg Roedel <joro@8bytes.org>
Cc: Christoph Hellwig <hch@infradead.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Tom Murphy <murphyt7@tcd.ie>
Subject: Re: [PATCH] iommu/amd: flush not present cache in iommu_map_page
Date: Wed, 24 Apr 2019 07:58:19 -0700 [thread overview]
Message-ID: <20190424145819.GA16141@infradead.org> (raw)
In-Reply-To: <CAPL0++7w0wR+hid=0XkGtH2wR0qvL1oNheEMQOM=8CtyhNLmag@mail.gmail.com>
On Wed, Apr 24, 2019 at 03:47:39PM +0100, Tom Murphy wrote:
> >And I'd really like to understand the unlikely - amd_iommu_np_cache
> >is set based on a hardware capability, so it seems rather odd to mark
> >it unlikely. Dynamic branch prediction really should do the right thing
> >here usually.
>
> Here is the commit which added it without any explanation:
> https://github.com/torvalds/linux/commit/270cab2426cdc6307725e4f1f46ecf8ab8e69193
>
> should we remove it seen as there's no explanation given ?
I'd be tempted to do that. But lets just ask Joerg if he has
any opinion..
next prev parent reply other threads:[~2019-04-24 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 14:18 [PATCH] iommu/amd: flush not present cache in iommu_map_page Tom Murphy
2019-04-24 14:32 ` Christoph Hellwig
2019-04-24 14:47 ` Tom Murphy
2019-04-24 14:58 ` Christoph Hellwig [this message]
2019-04-24 15:55 ` Joerg Roedel
2019-04-24 16:25 ` Tom Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424145819.GA16141@infradead.org \
--to=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=murphyt7@tcd.ie \
--cc=tmurphy@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox