From: Joerg Roedel <joro@8bytes.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Tom Murphy <tmurphy@arista.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Tom Murphy <murphyt7@tcd.ie>
Subject: Re: [PATCH] iommu/amd: flush not present cache in iommu_map_page
Date: Wed, 24 Apr 2019 17:55:06 +0200 [thread overview]
Message-ID: <20190424155505.GA6731@8bytes.org> (raw)
In-Reply-To: <20190424145819.GA16141@infradead.org>
On Wed, Apr 24, 2019 at 07:58:19AM -0700, Christoph Hellwig wrote:
> I'd be tempted to do that. But lets just ask Joerg if he has
> any opinion..
The reason was that it is an unlikely path, as hardware implementations
are not allowed to set this bit. It is purely for emulated AMD IOMMUs.
I have not measured whether this annotation has any performance
benefit, but I find it more readable at least.
Regards,
Joerg
PS: Why did you drop me from the Cc list of the previous replies?
next prev parent reply other threads:[~2019-04-24 15:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 14:18 [PATCH] iommu/amd: flush not present cache in iommu_map_page Tom Murphy
2019-04-24 14:32 ` Christoph Hellwig
2019-04-24 14:47 ` Tom Murphy
2019-04-24 14:58 ` Christoph Hellwig
2019-04-24 15:55 ` Joerg Roedel [this message]
2019-04-24 16:25 ` Tom Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424155505.GA6731@8bytes.org \
--to=joro@8bytes.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=murphyt7@tcd.ie \
--cc=tmurphy@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox