From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E8FC10F11 for ; Wed, 24 Apr 2019 16:57:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B45F1206A3 for ; Wed, 24 Apr 2019 16:57:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733051AbfDXQ54 (ORCPT ); Wed, 24 Apr 2019 12:57:56 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:60804 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731724AbfDXQ54 (ORCPT ); Wed, 24 Apr 2019 12:57:56 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 1F4E1200AD; Wed, 24 Apr 2019 18:57:53 +0200 (CEST) Date: Wed, 24 Apr 2019 18:57:51 +0200 From: Sam Ravnborg To: John Stultz Cc: Xu YiPing , David Airlie , Chen Feng , lkml , dri-devel , Xinliang Liu , Xinwei Kong , Rongrong Zou Subject: Re: [PATCH 12/25] drm: kirin: Reanme dc_ops to kirin_drm_data Message-ID: <20190424165751.GB21067@ravnborg.org> References: <1556061656-1733-1-git-send-email-john.stultz@linaro.org> <1556061656-1733-13-git-send-email-john.stultz@linaro.org> <20190424165226.GE20110@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190424165226.GE20110@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=BTeA3XvPAAAA:8 a=pGLkceISAAAA:8 a=e5mUnYsNAAAA:8 a=KKAkSRfTAAAA:8 a=oFkJ97iAnQrfrlizSGYA:9 a=CjuIK1q_8ugA:10 a=tafbbOV3vt1XuEhzTjGK:22 a=Vxmtnl_E_bksehYqCbjh:22 a=cvBusfyB2V15izCimMoJ:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi again. On Wed, Apr 24, 2019 at 06:52:26PM +0200, Sam Ravnborg wrote: > Hi John. > > On Tue, Apr 23, 2019 at 04:20:43PM -0700, John Stultz wrote: > > From: Xu YiPing > > > > As part of refactoring the kirin driver to better support > > different hardware revisions, this patch renames the > > struct kirin_dc_ops to struct kirin_drm_data and cleans > > up the related variable names. > > > > Cc: Xinliang Liu > > Cc: Rongrong Zou > > Cc: Xinwei Kong > > Cc: Chen Feng > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: dri-devel > > Signed-off-by: Xu YiPing > > [jstultz: reworded commit message] > > Signed-off-by: John Stultz > > --- > > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +- > > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 16 ++++++++-------- > > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h | 4 ++-- > > 3 files changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c > > index 69604ad..221bfbb 100644 > > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c > > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c > > @@ -1055,7 +1055,7 @@ static void ade_drm_cleanup(struct platform_device *pdev) > > { > > } > > > > -const struct kirin_dc_ops ade_dc_ops = { > > +struct kirin_drm_data ade_driver_data = { > > .init = ade_drm_init, > > .cleanup = ade_drm_cleanup > > }; > This rename does not help readability. An _ops often/always hold > function pointers. Where _data hold data. > So it looks wrong to name this _data. Reading later pathes the rename makes good sense, so disregard this. Sam